Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-05 Thread Sid Wagle 


> On Dec. 5, 2017, 4:56 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
> > Lines 72 (patched)
> > 
> >
> > Maybe also logger.info "This stack does not indicate that it supports 
> > LZO installation"

Good point. Thanks for the quick review will make those changes before commit.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64315/#review192882
---


On Dec. 5, 2017, 4:51 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64315/
> ---
> 
> (Updated Dec. 5, 2017, 4:51 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22588
> https://issues.apache.org/jira/browse/AMBARI-22588
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> IOP Migration: Hive Client restart fails: hadooplzo package not present in 
> iop repos
> 
> *STR*:
> - Install IOP-425 cluster
> - Now upgrade Ambari to 2.6.1. Hive client restart fails
> 
> {code}
> Cannot match package for regexp name hadooplzo_${stack_version}
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
>  68ee607 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  d29efb2 
> 
> 
> Diff: https://reviews.apache.org/r/64315/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-05 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64315/#review192882
---


Ship it!




2 small nits


ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
Lines 60 (patched)


you can just do:
check_stack_feature(StackFeature.LZO, stack_version_unformatted)



ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
Lines 72 (patched)


Maybe also logger.info "This stack does not indicate that it supports LZO 
installation"


- Jonathan Hurley


On Dec. 5, 2017, 11:51 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64315/
> ---
> 
> (Updated Dec. 5, 2017, 11:51 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22588
> https://issues.apache.org/jira/browse/AMBARI-22588
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> IOP Migration: Hive Client restart fails: hadooplzo package not present in 
> iop repos
> 
> *STR*:
> - Install IOP-425 cluster
> - Now upgrade Ambari to 2.6.1. Hive client restart fails
> 
> {code}
> Cannot match package for regexp name hadooplzo_${stack_version}
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
>  68ee607 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  d29efb2 
> 
> 
> Diff: https://reviews.apache.org/r/64315/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-05 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64315/
---

(Updated Dec. 5, 2017, 4:51 p.m.)


Review request for Ambari, Aravindan Vijayan and Jonathan Hurley.


Changes
---

Preliminary patch for review: Using stack_features instead of stack code change.


Bugs: AMBARI-22588
https://issues.apache.org/jira/browse/AMBARI-22588


Repository: ambari


Description
---

IOP Migration: Hive Client restart fails: hadooplzo package not present in iop 
repos

*STR*:
- Install IOP-425 cluster
- Now upgrade Ambari to 2.6.1. Hive client restart fails

{code}
Cannot match package for regexp name hadooplzo_${stack_version}
{code}


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
 68ee607 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
 d29efb2 


Diff: https://reviews.apache.org/r/64315/diff/2/

Changes: https://reviews.apache.org/r/64315/diff/1-2/


Testing
---

mvn clean test


Thanks,

Sid Wagle

Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-04 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64315/#review192776
---


Ship it!




Ship It!

- Jonathan Hurley


On Dec. 4, 2017, 3:33 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64315/
> ---
> 
> (Updated Dec. 4, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22588
> https://issues.apache.org/jira/browse/AMBARI-22588
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> IOP Migration: Hive Client restart fails: hadooplzo package not present in 
> iop repos
> 
> *STR*:
> - Install IOP-425 cluster
> - Now upgrade Ambari to 2.6.1. Hive client restart fails
> 
> {code}
> Cannot match package for regexp name hadooplzo_${stack_version}
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/alerts/alert_hive_interactive_thrift_port.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/alerts/alert_hive_metastore.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/alerts/alert_hive_thrift_port.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/alerts/alert_llap_app_status.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/alerts/alert_webhcat_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/etc/hive-schema-0.12.0.mysql.sql
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/etc/hive-schema-0.12.0.oracle.sql
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/etc/hive-schema-0.12.0.postgres.sql
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/addMysqlUser.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/hcatSmoke.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/hiveSmoke.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/hiveTezSetup.cmd
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/hiveserver2.sql
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/hiveserver2Smoke.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/pigSmoke.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/removeMysqlUser.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/startMetastore.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/files/templetonSmoke.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/__init__.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hcat.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hcat_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hcat_service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive_interactive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive_metastore.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive_server_interactive.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HIVE/package/scripts/hive_server_upgrade.py
>  PRE-CREATION 
>   
>