Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review130753
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On April 27, 2016, 9:45 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 27, 2016, 9:45 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/
---

(Updated April 27, 2016, 9:45 a.m.)


Review request for Ambari and Sreenath Somarajapuram.


Changes
---

Patch updated with comments


Bugs: AMBARI-15384
https://issues.apache.org/jira/browse/AMBARI-15384


Repository: ambari


Description
---

Revamping the old capsched UI into new better one


Diffs (updated)
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
ac679b7 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
16b7d0a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js 
PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
05bb64c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a2d50b9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 be79229 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
25e2aa9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44704/diff/


Testing
---

Manual unit testing


Thanks,

Akhil PB

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Akhil PB 


> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs,
> >  line 28
> > 
> >
> > Whay are we having an anchor tags inside link-to? And what is the 
> > purpose fo href="view.href".
> 
> Akhil PB wrote:
> Here link-to tag is li, not anchor. When link-to is clicked, ember would 
> add active class to link-to element. Since we have tab structure, I have used 
> this to show active tab whenever user clicks on tab.
> Please refer 
> http://stackoverflow.com/questions/11628489/emberjs-how-to-mark-active-menu-item-using-router-infrastructure

Rewrote as Scheduler


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126795
---


On April 26, 2016, 10:43 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 26, 2016, 10:43 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review130740
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 138)


Where is operation defined?


- Sreenath Somarajapuram


On April 26, 2016, 10:43 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 26, 2016, 10:43 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-26 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/
---

(Updated April 26, 2016, 10:43 a.m.)


Review request for Ambari and Sreenath Somarajapuram.


Changes
---

Patch with updated changes


Bugs: AMBARI-15384
https://issues.apache.org/jira/browse/AMBARI-15384


Repository: ambari


Description
---

Revamping the old capsched UI into new better one


Diffs (updated)
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
ac679b7 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
16b7d0a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js 
PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
05bb64c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a2d50b9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 be79229 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
25e2aa9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44704/diff/


Testing
---

Manual unit testing


Thanks,

Akhil PB

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-21 Thread Akhil PB 


> On April 4, 2016, 10:45 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs,
> >  line 60
> > 
> >
> > Can use bunded conditional class names.

This got changed in later commits. I guess I would face conflicts in future 
patches. Timebeing I will do this.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126808
---


On April 13, 2016, 7:18 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 13, 2016, 7:18 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thank

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-13 Thread Akhil PB 


> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js,
> >  line 19
> > 
> >
> > Looks like you can delete this file.
> > Even if the file name is queueMappingParser.js, this is same as 
> > queueMappingInterpreter.js.
> > Also correct th require.

This file is removed.


> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs,
> >  line 28
> > 
> >
> > Whay are we having an anchor tags inside link-to? And what is the 
> > purpose fo href="view.href".

Here link-to tag is li, not anchor. When link-to is clicked, ember would add 
active class to link-to element. Since we have tab structure, I have used this 
to show active tab whenever user clicks on tab.
Please refer 
http://stackoverflow.com/questions/11628489/emberjs-how-to-mark-active-menu-item-using-router-infrastructure


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126795
---


On April 13, 2016, 7:18 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 13, 2016, 7:18 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/a

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-13 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/
---

(Updated April 13, 2016, 7:18 a.m.)


Review request for Ambari and Sreenath Somarajapuram.


Changes
---

Fixed the review comments and updated diff with latest fixed patch.


Bugs: AMBARI-15384
https://issues.apache.org/jira/browse/AMBARI-15384


Repository: ambari


Description
---

Revamping the old capsched UI into new better one


Diffs (updated)
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
ac679b7 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
16b7d0a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js 
PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
05bb64c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a2d50b9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 be79229 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
25e2aa9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44704/diff/


Testing
---

Manual unit testing


Thanks,

Akhil PB

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126813
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 76)


Commented code.


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126808
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 (line 27)


Intentation



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 (line 60)


Can use bunded conditional class names.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 (line 33)


please correct the intentation.



contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
(line 28)


Better to off these listeners on willDestroy.


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/r

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126795
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 (line 19)


Looks like you can delete this file.
Even if the file name is queueMappingParser.js, this is same as 
queueMappingInterpreter.js.
Also correct th require.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 142)


We souldnt have commented code.
The line can be removed if not required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 229)


All debug logs must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 241)


All debug logs must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 275)


Again remove comments.



contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 (line 887)


Intentation



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 (line 28)


Whay are we having an anchor tags inside link-to? And what is the purpose 
fo href="view.href".


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queues

Review Request 44704: CapSched View: Revamping the old UI

2016-03-11 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/
---

Review request for Ambari and Sreenath Somarajapuram.


Bugs: AMBARI-15384
https://issues.apache.org/jira/browse/AMBARI-15384


Repository: ambari


Description
---

Revamping the old capsched UI into new better one


Diffs
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
ac679b7 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
16b7d0a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js 
PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
05bb64c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a2d50b9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 be79229 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
25e2aa9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44704/diff/


Testing
---

Manual unit testing


Thanks,

Akhil PB