Re: Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

[Aravindan Vijayan]

> On April 5, 2016, 8:54 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java,
> >  line 51
> > 
> >
> > Can values be null ?

No. This is inside an "if (metricValues != null && !metricValues.isEmpty())" 
block.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45772/#review127209
---


On April 5, 2016, 8:14 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45772/
> ---
> 
> (Updated April 5, 2016, 8:14 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15638
> https://issues.apache.org/jira/browse/AMBARI-15638
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Including Zero values in METRIC_RECORD METRIC_COUNT.
> 2. Fixing issue in TimelineMetricClusterAggregatorSecond
> 3. Fixing issue in AVG() call in Phoenix query for higher level aggregates.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
>  126b3a3 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  67c463f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  e3030f6 
> 
> Diff: https://reviews.apache.org/r/45772/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45772/#review127209
---


Ship it!





ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
 (line 48)


Can values be null ?



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 245)


No need to braces.


- Sid Wagle


On April 5, 2016, 8:14 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45772/
> ---
> 
> (Updated April 5, 2016, 8:14 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15638
> https://issues.apache.org/jira/browse/AMBARI-15638
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Including Zero values in METRIC_RECORD METRIC_COUNT.
> 2. Fixing issue in TimelineMetricClusterAggregatorSecond
> 3. Fixing issue in AVG() call in Phoenix query for higher level aggregates.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
>  126b3a3 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  67c463f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  e3030f6 
> 
> Diff: https://reviews.apache.org/r/45772/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45772/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15638
https://issues.apache.org/jira/browse/AMBARI-15638


Repository: ambari


Description
---

1. Including Zero values in METRIC_RECORD METRIC_COUNT.
2. Fixing issue in TimelineMetricClusterAggregatorSecond
3. Fixing issue in AVG() call in Phoenix query for higher level aggregates.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
 126b3a3 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 67c463f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 e3030f6 

Diff: https://reviews.apache.org/r/45772/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan