Re: Review Request 46729: [preview] Force running service checks for services before upgrade

2016-04-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46729/#review130810 --- ambari-server/src/main/java/org/apache/ambari/server/checks/Servi

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

2016-04-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46729/#review130807 --- ambari-server/src/main/java/org/apache/ambari/server/checks/Check

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

2016-04-27 Thread Nate Cole
> On April 27, 2016, 12:39 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java, > > lines 112-123 > > > > > > I don't think we want a "break;" here -

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

2016-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46729/#review130804 --- ambari-server/src/main/java/org/apache/ambari/server/checks/Check

Review Request 46729: [preview] Force running service checks for services before upgrade

2016-04-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46729/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.