Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-11 Thread Matt


> On May 10, 2016, 12:13 p.m., jun aoki wrote:
> > Do we have to Clean PXF from the previous NN node, if the node does no 
> > longer have any of PXF related ones? (DN, HAWQ etc.?)

Did you mean to say, remove the rpms and files?
I would be looking into this on a follow-up JIRA.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132518
---


On May 10, 2016, 12:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 12:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread bhuvnesh chaudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132531
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132518
---



Do we have to Clean PXF from the previous NN node, if the node does no longer 
have any of PXF related ones? (DN, HAWQ etc.?)

- jun aoki


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread Lav Jain

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132512
---


Ship it!




Ship It!

- Lav Jain


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread Lav Jain

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132511
---




ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
(line 235)


+1 for comprehensive test code


- Lav Jain


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132476
---


Ship it!




Ship It!

- Goutam Tadi


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread Matt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
jun aoki, and Lav Jain.


Bugs: AMBARI-16419
https://issues.apache.org/jira/browse/AMBARI-16419


Repository: ambari


Description
---

After move NAMENODE wizard is executed,
- PXF should be installed on the target host.
- If the source host does not have a DATANODE, PXF should be removed from the 
source host.


Diffs
-

  ambari-web/app/controllers/main/service/reassign/step6_controller.js f718d46 
  ambari-web/app/messages.js e388526 
  ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
89e2325 

Diff: https://reviews.apache.org/r/47160/diff/


Testing
---

Added unit tests.

  27727 tests complete (25 seconds)
  154 tests pending
  
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:14 min
[INFO] Finished at: 2016-05-10T00:20:54-07:00
[INFO] Final Memory: 12M/310M
[INFO] 


Thanks,

Matt