Re: Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values

2016-05-12 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/
---

(Updated May 12, 2016, 7:31 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16443
https://issues.apache.org/jira/browse/AMBARI-16443


Repository: ambari


Description
---

- Introduced a settingException variable
- settingException variable gets the name and value for the failed setting 
parameter.
- we display error the error message for the failed setting while saving the 
settings.


Diffs (updated)
-

  contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
b813bbf 

Diff: https://reviews.apache.org/r/47224/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values

2016-05-11 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/#review132836
---




contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
(line 132)


Use Ember.isEmpty or Ember.isBlank for this.


- DIPAYAN BHOWMICK


On May 11, 2016, 9:18 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47224/
> ---
> 
> (Updated May 11, 2016, 9:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16443
> https://issues.apache.org/jira/browse/AMBARI-16443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Introduced a settingException variable
> - settingException variable gets the name and value for the failed setting 
> parameter.
> - we display error the error message for the failed setting while saving the 
> settings.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> b813bbf 
> 
> Diff: https://reviews.apache.org/r/47224/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values

2016-05-11 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/#review132826
---


Ship it!




Ship It!

- Gaurav Nagar


On May 11, 2016, 9:18 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47224/
> ---
> 
> (Updated May 11, 2016, 9:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16443
> https://issues.apache.org/jira/browse/AMBARI-16443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Introduced a settingException variable
> - settingException variable gets the name and value for the failed setting 
> parameter.
> - we display error the error message for the failed setting while saving the 
> settings.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> b813bbf 
> 
> Diff: https://reviews.apache.org/r/47224/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values

2016-05-11 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16443
https://issues.apache.org/jira/browse/AMBARI-16443


Repository: ambari


Description
---

- Introduced a settingException variable
- settingException variable gets the name and value for the failed setting 
parameter.
- we display error the error message for the failed setting while saving the 
settings.


Diffs
-

  contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
b813bbf 

Diff: https://reviews.apache.org/r/47224/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha