Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-31 Thread Sangeeta Ravindran 


> On May 30, 2016, 10:22 a.m., Andrii Tkach wrote:
> > Ship It!

Thank you.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135491
---


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-31 Thread Sangeeta Ravindran 


> On May 30, 2016, 11:19 a.m., Alexandr Antonenko wrote:
> > committed to trunk and branch-2.4

Thank you!


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135496
---


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-30 Thread Alexandr Antonenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135496
---



committed to trunk and branch-2.4

- Alexandr Antonenko


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-30 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135491
---


Ship it!




Ship It!

- Andrii Tkach


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-28 Thread Sangeeta Ravindran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/
---

Review request for Ambari, Alexandr Antonenko and Andrii Tkach.


Bugs: AMBARI-16941
https://issues.apache.org/jira/browse/AMBARI-16941


Repository: ambari


Description
---

1. Open Cluster Install Wizard and select Knox as the only service to install.
2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on Next 
and proceed because of an error in the javascript code.
3. The javascript error is as follows:
4. TypeError: h.warnMessages is undefined

app.js (line 38401, col 49)
TypeError: h.warnMessages is undefined


...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 0; 
})


Diffs
-

  ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
  ambari-web/test/controllers/wizard/step6_test.js 56b9e96 

Diff: https://reviews.apache.org/r/47995/diff/


Testing
---

Manual test
Added testcases to test anyHostErrors and anyHostWarnings methods.
mvn test ran clean

 27862 tests complete (44 seconds)
  154 tests pending


Thanks,

Sangeeta Ravindran