Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

[Prajwal Rao]

> On June 24, 2016, 4:54 p.m., Prajwal Rao wrote:
> > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js, lines 
> > 128-133
> > 
> >
> > All graphs on HBase-Users have legend hidden.
> > 
> > We do need to handle this on aggregate level dashboards and graphs, and 
> > I already have a separate fix for that.
> 
> Jungtaek Lim wrote:
> Prajwal Rao
> I'm sorry but I don't get your feedback.
> I just would like to show alias instead of raw metric name since it could 
> be too long and not beauty to show when we introduce series aggregation ('%' 
> will be used to metric name). But I may miss some spots in patch since I 
> understand this javascript partially.
> 
> If you already have a patch to cover this issue, please let me know. I'd 
> be happy to close the review. You can also close issue AMBARI-17416 as 
> duplicated or take over.

Jungtaek, You can close this review. I have taken over AMBARI-17416 and will 
update the JIRA accordingly.


- Prajwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
---


On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> ---
> 
> (Updated June 24, 2016, 1:42 a.m.)
> 
> 
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17416
> https://issues.apache.org/jira/browse/AMBARI-17416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When there's no datapoint available, AMS Grafana plugin just ignores alias 
> and shows metric name instead. It seems to be not consistent in point of 
> view, and not good UX I think.
> 
> It'd be great AMS Grafana shows alias whenever there're datapoints available 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 
> 
> Diff: https://reviews.apache.org/r/49173/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Actually this is tiny fix so we can imagine how it will make 
> change.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

[Jungtaek Lim]

> On 6 24, 2016, 4:54 오후, Prajwal Rao wrote:
> > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js, lines 
> > 128-133
> > 
> >
> > All graphs on HBase-Users have legend hidden.
> > 
> > We do need to handle this on aggregate level dashboards and graphs, and 
> > I already have a separate fix for that.

Prajwal Rao
I'm sorry but I don't get your feedback.
I just would like to show alias instead of raw metric name since it could be 
too long and not beauty to show when we introduce series aggregation ('%' will 
be used to metric name). But I may miss some spots in patch since I understand 
this javascript partially.

If you already have a patch to cover this issue, please let me know. I'd be 
happy to close the review. You can also close issue AMBARI-17416 as duplicated 
or take over.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
---


On 6 24, 2016, 1:42 오전, Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> ---
> 
> (Updated 6 24, 2016, 1:42 오전)
> 
> 
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17416
> https://issues.apache.org/jira/browse/AMBARI-17416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When there's no datapoint available, AMS Grafana plugin just ignores alias 
> and shows metric name instead. It seems to be not consistent in point of 
> view, and not good UX I think.
> 
> It'd be great AMS Grafana shows alias whenever there're datapoints available 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 
> 
> Diff: https://reviews.apache.org/r/49173/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Actually this is tiny fix so we can imagine how it will make 
> change.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

[Prajwal Rao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
---




ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 100 - 
105)


All graphs on Kafka-Topics have legend hidden.



ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 128 - 
133)


All graphs on HBase-Users have legend hidden.

We do need to handle this on aggregate level dashboards and graphs, and I 
already have a separate fix for that.


- Prajwal Rao


On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> ---
> 
> (Updated June 24, 2016, 1:42 a.m.)
> 
> 
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17416
> https://issues.apache.org/jira/browse/AMBARI-17416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When there's no datapoint available, AMS Grafana plugin just ignores alias 
> and shows metric name instead. It seems to be not consistent in point of 
> view, and not good UX I think.
> 
> It'd be great AMS Grafana shows alias whenever there're datapoints available 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 
> 
> Diff: https://reviews.apache.org/r/49173/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Actually this is tiny fix so we can imagine how it will make 
> change.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

[Jungtaek Lim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/
---

Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku Sako.


Bugs: AMBARI-17416
https://issues.apache.org/jira/browse/AMBARI-17416


Repository: ambari


Description
---

When there's no datapoint available, AMS Grafana plugin just ignores alias and 
shows metric name instead. It seems to be not consistent in point of view, and 
not good UX I think.

It'd be great AMS Grafana shows alias whenever there're datapoints available or 
not.


Diffs
-

  ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 

Diff: https://reviews.apache.org/r/49173/diff/


Testing
---

Tested manually. Actually this is tiny fix so we can imagine how it will make 
change.


Thanks,

Jungtaek Lim