Re: Review Request 49804: improve resourcemanager HA description

[wang yaoxin]

> On 九月 13, 2016, 2:30 p.m., Aleksandr Kovalenko wrote:
> > Ship It!

Thanks Aleksandr,  I am very glad if you could help me  to commit the patch.


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review148726
---


On 九月 12, 2016, 3:24 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated 九月 12, 2016, 3:24 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, jun aoki, Zhe (Joe) Wang, 
> Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review148726
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Сен. 12, 2016, 3:24 д.п., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated Сен. 12, 2016, 3:24 д.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, jun aoki, Zhe (Joe) Wang, 
> Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[Aleksandr Kovalenko]

> On Сен. 12, 2016, 9:08 д.п., Aleksandr Kovalenko wrote:
> > ambari-web/app/models/host_component.js, line 333
> > 
> >
> > What is the reason for this change?
> > Why we decide to not show Enable label if HA is already enabled?
> 
> wang yaoxin wrote:
> Thank you ,Aleksandr . Just like the NameNode HA , it's better to decide 
> the RM Enable lable and cssClass

I see, thanks.


- Aleksandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review148468
---


On Сен. 12, 2016, 3:24 д.п., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated Сен. 12, 2016, 3:24 д.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, jun aoki, Zhe (Joe) Wang, 
> Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[wang yaoxin]

> On 九月 12, 2016, 9:08 a.m., Aleksandr Kovalenko wrote:
> > ambari-web/app/models/host_component.js, line 333
> > 
> >
> > What is the reason for this change?
> > Why we decide to not show Enable label if HA is already enabled?

Thank you ,Aleksandr . Just like the NameNode HA , it's better to decide the RM 
Enable lable and cssClass


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review148468
---


On 九月 12, 2016, 3:24 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated 九月 12, 2016, 3:24 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, jun aoki, Zhe (Joe) Wang, 
> Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review148468
---




ambari-web/app/models/host_component.js (line 333)


What is the reason for this change?
Why we decide to not show Enable label if HA is already enabled?


- Aleksandr Kovalenko


On Сен. 12, 2016, 3:24 д.п., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated Сен. 12, 2016, 3:24 д.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, jun aoki, Zhe (Joe) Wang, 
> Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[Nate Cole]

> On Sept. 6, 2016, 3:41 p.m., Nate Cole wrote:
> > Ship It!
> 
> wang yaoxin wrote:
> Thank you , but I don't have the authority to ship, so i will trouble you 
> to  commit the patch!

A review needs 2 approvals before being pushed.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review147904
---


On Sept. 6, 2016, 5:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated Sept. 6, 2016, 5:57 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[wang yaoxin]

> On 九月 6, 2016, 7:41 p.m., Nate Cole wrote:
> > Ship It!

Thank you , but I don't have the authority to ship, so i will trouble you to  
commit the patch!


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review147904
---


On 九月 6, 2016, 9:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated 九月 6, 2016, 9:57 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49804: improve resourcemanager HA description

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review147904
---


Ship it!




Ship It!

- Nate Cole


On Sept. 6, 2016, 5:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49804/
> ---
> 
> (Updated Sept. 6, 2016, 5:57 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-17518
> https://issues.apache.org/jira/browse/AMBARI-17518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> improve the resourcemanager HA description
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 973b809 
> 
> Diff: https://reviews.apache.org/r/49804/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Review Request 49804: improve resourcemanager HA description

[wang yaoxin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/
---

Review request for Ambari.


Bugs: AMBARI-17518
https://issues.apache.org/jira/browse/AMBARI-17518


Repository: ambari


Description
---

improve the resourcemanager HA description


Diffs
-

  ambari-web/app/models/host_component.js 973b809 

Diff: https://reviews.apache.org/r/49804/diff/


Testing
---

done


Thanks,

wang yaoxin