Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-24 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146687
---



Reverted patch since underlying problem was fixed by AMBARI-18256 
(https://reviews.apache.org/r/51383/)
commit e0e708f66fc46b514455d84552cb21670849491c

- Alejandro Fernandez


On Aug. 23, 2016, 10:34 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
> 
> (Updated Aug. 23, 2016, 10:34 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
> version as host. Skipping version update
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/51296/diff/
> 
> 
> Testing
> ---
> 
> on live cluster
> unit test run
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-23 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/
---

(Updated Aug. 23, 2016, 1:34 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-18231
https://issues.apache.org/jira/browse/AMBARI-18231


Repository: ambari


Description
---

Noticed in the stack deploy runs:
{code}
20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
version as host. Skipping version update
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
537ae32 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
2dae526 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 905707c 

Diff: https://reviews.apache.org/r/51296/diff/


Testing (updated)
---

on live cluster
unit test run


Thanks,

Dmitro Lisnichenko

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146447
---


Ship it!




This logic makes me a bit nauseous; it's definitely not very clean with methods 
that say "Don't use me unless you're a unit test". With that said, the changes 
make this a bit better. The inheritence of this field is bound to get messed up 
in the future.

- Jonathan Hurley


On Aug. 22, 2016, 2:25 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
> 
> (Updated Aug. 22, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
> version as host. Skipping version update
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/51296/diff/
> 
> 
> Testing
> ---
> 
> on live cluster
> unit test run in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146426
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 22, 2016, 6:25 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
> 
> (Updated Aug. 22, 2016, 6:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
> version as host. Skipping version update
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/51296/diff/
> 
> 
> Testing
> ---
> 
> on live cluster
> unit test run in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Alejandro Fernandez 


> On Aug. 22, 2016, 7:33 p.m., Nate Cole wrote:
> > Just confirm with Alejandro why he had both a field and a value.

One was a boolean to read from the XML file, and the other is the actual 
calculation by reading from the parent if the XML file did not explicitly 
provide a value.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146414
---


On Aug. 22, 2016, 6:25 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
> 
> (Updated Aug. 22, 2016, 6:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
> version as host. Skipping version update
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/51296/diff/
> 
> 
> Testing
> ---
> 
> on live cluster
> unit test run in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146414
---


Ship it!




Just confirm with Alejandro why he had both a field and a value.

- Nate Cole


On Aug. 22, 2016, 2:25 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
> 
> (Updated Aug. 22, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
> version as host. Skipping version update
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/51296/diff/
> 
> 
> Testing
> ---
> 
> on live cluster
> unit test run in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146395
---




ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
(line 53)


main fix is to remove default value


- Dmitro Lisnichenko


On Aug. 22, 2016, 9:25 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
> 
> (Updated Aug. 22, 2016, 9:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
> version as host. Skipping version update
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  537ae32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 2dae526 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  905707c 
> 
> Diff: https://reviews.apache.org/r/51296/diff/
> 
> 
> Testing
> ---
> 
> on live cluster
> unit test run in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18231
https://issues.apache.org/jira/browse/AMBARI-18231


Repository: ambari


Description
---

Noticed in the stack deploy runs:
{code}
20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] 
StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, 
however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised 
version as host. Skipping version update
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
537ae32 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
2dae526 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 905707c 

Diff: https://reviews.apache.org/r/51296/diff/


Testing
---

on live cluster
unit test run in progress


Thanks,

Dmitro Lisnichenko