Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. > > Amruta Borkar wrote: > Thank you Robert, could you please help me push this to trunk? > > Robert Nettleton wrote: > Hi Amruta, > > Sure, I can push this to trunk today. > > Robert Nettleton wrote: > Hi Amruta, > > I've pushed this patch into trunk. > > Can you please close out the review and the associated JIRA? > > Thanks. Ok. Thank you. - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148198 --- On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. > > Amruta Borkar wrote: > Thank you Robert, could you please help me push this to trunk? > > Robert Nettleton wrote: > Hi Amruta, > > Sure, I can push this to trunk today. Hi Amruta, I've pushed this patch into trunk. Can you please close out the review and the associated JIRA? Thanks. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148198 --- On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. > > Amruta Borkar wrote: > Thank you Robert, could you please help me push this to trunk? Hi Amruta, Sure, I can push this to trunk today. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148198 --- On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
> On Sept. 8, 2016, 4:06 p.m., Robert Nettleton wrote: > > The patch looks fine to me. > > > > Thanks for catching and fixing this bug. Thank you Robert, could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148198 --- On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
> On Sept. 8, 2016, 8:03 a.m., Laszlo Puskas wrote: > > Ship It! Thank you Laszlo. - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148157 --- On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148198 --- Ship it! The patch looks fine to me. Thanks for catching and fixing this bug. - Robert Nettleton On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Re: Review Request 51708: While checking for component dependency code looks for incorrect component name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/#review148157 --- Ship it! Ship It! - Laszlo Puskas On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51708/ > --- > > (Updated Sept. 7, 2016, 10:03 p.m.) > > > Review request for Ambari, Laszlo Puskas and Robert Nettleton. > > > Bugs: AMBARI-18333 > https://issues.apache.org/jira/browse/AMBARI-18333 > > > Repository: ambari > > > Description > --- > > While validating host groups in blueprint for component dependency, code > should check if a dependency component is present in the host group component > list rather than the component on whose dependency list it is iterating. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 398772e > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > ea6bee3 > > Diff: https://reviews.apache.org/r/51708/diff/ > > > Testing > --- > > Added Test cases, performed manual testing > > > Thanks, > > Amruta Borkar > >
Review Request 51708: While checking for component dependency code looks for incorrect component name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51708/ --- Review request for Ambari, Laszlo Puskas and Robert Nettleton. Bugs: AMBARI-18333 https://issues.apache.org/jira/browse/AMBARI-18333 Repository: ambari Description --- While validating host groups in blueprint for component dependency, code should check if a dependency component is present in the host group component list rather than the component on whose dependency list it is iterating. Diffs - ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 398772e ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java ea6bee3 Diff: https://reviews.apache.org/r/51708/diff/ Testing --- Added Test cases, performed manual testing Thanks, Amruta Borkar
