Re: Review Request 62770: Log Search UI: reorganize classes structure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187085 --- Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62770/ > --- > > (Updated Oct. 4, 2017, 12:44 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-22129 > https://issues.apache.org/jira/browse/AMBARI-22129 > > > Repository: ambari > > > Description > --- > > Locate model classes and other ones in one directory to avoid confusion, > since model classes can be used not only in storage-related code. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts > d3d7d95 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts > dee5d98 > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts > 1aaaecc > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts > 3727abb > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts > 83c3261 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts > efa2459 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts > 2e2113f > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts > 864b689 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts > da05cee > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts > 15c05fb > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 43d79f8 > >
Re: Review Request 62770: Log Search UI: reorganize classes structure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187086 --- Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62770/ > --- > > (Updated Oct. 4, 2017, 12:44 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-22129 > https://issues.apache.org/jira/browse/AMBARI-22129 > > > Repository: ambari > > > Description > --- > > Locate model classes and other ones in one directory to avoid confusion, > since model classes can be used not only in storage-related code. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts > d3d7d95 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts > dee5d98 > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts > 1aaaecc > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts > 3727abb > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts > 83c3261 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts > efa2459 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts > 2e2113f > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts > 864b689 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts > da05cee > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts > 15c05fb > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 43d79f8 > >
Review Request 62770: Log Search UI: reorganize classes structure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-22129 https://issues.apache.org/jira/browse/AMBARI-22129 Repository: ambari Description --- Locate model classes and other ones in one directory to avoid confusion, since model classes can be used not only in storage-related code. Diffs - ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts d3d7d95 ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts dee5d98 ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 1aaaecc ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts 3727abb ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts 83c3261 ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts efa2459 ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts 2e2113f ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts 864b689 ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts da05cee ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts 15c05fb ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts PRE-CREATION ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts 43d79f8 ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts 656c901 ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts 1481583 ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts c345c81 ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.ts 467de98 ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts 7345288 ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts c94b967
