Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 14, 2015, 2:44 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 13, 2015, 9:48 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 334 > > > > > > Why bind to this? Leftover cruft from an earlier implementation (wherein I had p

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95425 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95427 --- src/main/resources/scheduler/assets/js/app.js (lines 35 - 38)

Review Request 37483: Suppressing "Unregistered executor" status message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37483/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1193 https://issue

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/app.js, lines 35-38 > > > > > > I feel like changing our URLs like this needs a deprecation path. This > > would break

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/#review95431 --- Ship it! src/main/java/org/apache/aurora/scheduler/Resources.java

Re: Review Request 37483: Suppressing "Unregistered executor" status message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37483/#review95432 --- Master (76d5a49) is red with this patch. ./build-support/jenkins/b

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/#review95434 --- Ship it! Ship It! - Joshua Cohen On Aug. 13, 2015, 9:46 p.m., Ma

Re: Review Request 37483: Suppressing "Unregistered executor" status message.

> On Aug. 14, 2015, 4:13 p.m., Aurora ReviewBot wrote: > > Master (76d5a49) is red with this patch. > > ./build-support/jenkins/build.sh > > > > [ant:checkstyle] > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:108: >

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37483: Suppressing "Unregistered executor" status message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37483/ --- (Updated Aug. 14, 2015, 4:34 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 37483: Suppressing "Unregistered executor" status message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37483/#review95440 --- Ship it! Ship It! - Zameer Manji On Aug. 14, 2015, 9:34 a.m., Ma

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37483: Suppressing "Unregistered executor" status message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37483/#review95443 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/ --- (Updated Aug. 14, 2015, 7:14 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/ --- (Updated Aug. 14, 2015, 7:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 14, 2015, 7:17 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95465 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/#review95466 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

> On Aug. 14, 2015, 4:11 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/Resources.java, line 187 > > > > > > nit: any reason this declaration was moved after it's usage? Just trying to make

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca