Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-29 Thread Stephan Erb
> On Aug. 26, 2015, 7:55 p.m., Zameer Manji wrote: > > The ticket referenced also talks about {{mesos.ip}}, will you also add > > support for that? > > Steve Niemitz wrote: > It's not exposed anywhere by mesos AFAIK. If someone can correct me I > can add it in another review. I have to a

Re: Review Request 37789: Refer to shared task_configs table for job updates.

2015-08-29 Thread Bill Farner
> On Aug. 26, 2015, 11:18 a.m., Maxim Khutornenko wrote: > > Any noticable impact on JobDetailsBenchmark after this change? Thanks for the nudge - turns out this patch broke that test due to schema requirements. Fixed, and will put results in the testing field. > On Aug. 26, 2015, 11:18 a.m.

Re: Review Request 37789: Refer to shared task_configs table for job updates.

2015-08-29 Thread Bill Farner
> On Aug. 26, 2015, 10:38 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java, > > line 162 > > > > > > Inline this method reference. Done. - Bill -

Re: Review Request 37789: Refer to shared task_configs table for job updates.

2015-08-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/ --- (Updated Aug. 29, 2015, 8:45 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 37789: Refer to shared task_configs table for job updates.

2015-08-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37789/#review96995 --- Ship it! Master (356eeac) is green with this patch. ./build-suppo

Review Request 37924: Deb: move clusters.json from aurora-executor to aurora-tools package.

2015-08-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37924/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Des

Re: Review Request 37825: Adding minimal implementation of the external tier config.

2015-08-29 Thread Maxim Khutornenko
> On Aug. 29, 2015, 5:41 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 73 > > > > > > What's preventing you from adding the annotation now? This file's presence is

Re: Review Request 37825: Adding minimal implementation of the external tier config.

2015-08-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 29, 2015, 6:34 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37825: Adding minimal implementation of the external tier config.

2015-08-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96997 --- Ship it! Master (782f883) is green with this patch. ./build-suppo

Review Request 37926: Adding oversubscription e2e tests.

2015-08-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora D

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review96998 --- This patch does not apply cleanly on master (782f883), do you need t

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Aug. 29, 2015, 9:04 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37924: Deb: move clusters.json from aurora-executor to aurora-tools package.

2015-08-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37924/#review96999 --- Ship it! Ship It! - Kevin Sweeney On Aug. 29, 2015, 9:38 a.m., B