Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Jeffrey Schroeder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/ --- (Updated Sept. 9, 2015, 1:36 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/#review98175 --- Ship it! Master (2773826) is green with this patch. ./build-suppo

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/#review98189 --- Ship it! I'll go ahead and commit this once the cleanups are addres

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Jeffrey Schroeder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/ --- (Updated Sept. 9, 2015, 2:52 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/#review98201 --- Ship it! Master (2773826) is green with this patch. ./build-suppo

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98203 --- Ship it! LGTM pending resolution of whatever merge conflicts are tr

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/#review98233 --- test/deb/ubuntu-trusty/Vagrantfile (lines 6 - 12)

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/ --- (Updated Sept. 9, 2015, 6:35 p.m.) Review request for Aurora, Joshua Cohen, Bil

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review98238 --- Ship it! Master (4577de4) is green with this patch. ./build-suppo

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/ --- (Updated Sept. 9, 2015, 7:10 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98260 --- Master (01e611a) is green with this patch. ./build-support/jenkins

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98268 --- Ship it! Ship It! - David McLaughlin On Sept. 9, 2015, 7:10 p.m.

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/#review98272 --- Ship it! LGTM once comments are addressed - Kevin Sweeney On Sep

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98274 --- Ship it! commons/src/main/java/org/apache/aurora/common/applicatio

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38202/#review98282 --- @ReviewBot retry - Zameer Manji On Sept. 8, 2015, 8:33 p.m., Zame

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Bill Farner
> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote: > > test/deb/ubuntu-trusty/Vagrantfile, lines 6-12 > > > > > > mutli-vm boilerplate isn't needed > > > > Can replace this block with > > > > ```ruby >

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/ --- (Updated Sept. 9, 2015, 3:19 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38202/#review98286 --- Ship it! Ship It! - Bill Farner On Sept. 8, 2015, 8:33 p.m., Zam

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Bill Farner
> On Sept. 9, 2015, 2:39 p.m., Kevin Sweeney wrote: > > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java, > > line 63 > > > > > > Looks like Modules.combine is redundant here. Thanks, remo

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 9, 2015, 3:24 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98297 --- Ship it! Master (a5ac5b9) is green with this patch. ./build-suppo

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38202/#review98302 --- Ship it! Master (a5ac5b9) is green with this patch. ./build-suppo

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98345 --- Maxim - ping. - Bill Farner On Sept. 8, 2015, 4:26 p.m., Bill Far