Review Request 39764: Add note to CONTRIBUTING.md about default reviewers.

2015-10-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39764/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 39764: Add note to CONTRIBUTING.md about default reviewers.

2015-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39764/#review104457 --- Ship it! Thanks! - Bill Farner On Oct. 29, 2015, 11:29 a.m., Jo

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Zameer Manji
> On Oct. 28, 2015, 8:02 a.m., Bill Farner wrote: > > It's not clear to me is why you didn't decide to return an immutable > > multimap copy and stay behind the previous interface. (Based on the > > typical characteristics of the map, and the way it's used here i don't > > imagine a big perf

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 29, 2015, 1:44 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104471 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 29, 2015, 8:44 p.

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104473 --- Ship it! Ship It! - Bill Farner On Oct. 29, 2015, 1:44 p.m., Za

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104475 --- @ReviewBot retry - Zameer Manji On Oct. 27, 2015, 4:38 p.m., Zam

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104479 --- Master (bcb4774) is red with this patch. ./build-support/jenkins/

Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Bugs: AURO

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/ --- (Updated Oct. 29, 2015, 3:06 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104483 --- John, would you mind filing a ticket to track the followup work to

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104484 --- Ship it! Would you also mind updating the commit message to point

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104487 --- pants.ini (line 27)

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104495 --- Master (bcb4774) is red with this patch. ./build-support/jenkins/

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104496 --- Master (bcb4774) is green with this patch. ./build-support/jenkin

Review Request 39797: Adding help message in case kerberos auth fails.

2015-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39797/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1364

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39797/#review104517 --- Ship it! Master (1b1c70c) is green with this patch. ./build-supp