Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread John Sirois
> On April 8, 2016, 11:20 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java, > > line 76 > > > > > > This causes the ordering of `eventTypes` to matt

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/ --- (Updated April 9, 2016, 8:37 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread John Sirois
> On April 7, 2016, 6:42 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 108 > > > > > > Shouldn't this be fatal? To me to looks like this

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review128016 --- Master (0dd096d) is red with this patch. ./build-support/jenkins

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread John Sirois
> On April 9, 2016, 8:41 p.m., Aurora ReviewBot wrote: > > Master (0dd096d) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :buildSrc:compileTestJava UP-TO-DATE > > :buildSrc:compileTestGroovy UP-TO-DATE > > :buildSrc:processTestResources UP-TO-DATE > > :buildSrc:testClass