Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Maxim Khutornenko
> On May 5, 2016, 6:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 177 > > > > > > Might be nice to add a helper method that does this check, rather than >

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/ --- (Updated May 5, 2016, 7:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/ --- (Updated May 5, 2016, 5 p.m.) Review request for Aurora, Joshua Cohen and Bill

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/#review131867 --- Master (f25a4b1) is red with this patch.

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/#review131878 --- Ship it!

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/#review131909 --- Ship it! Master (f25a4b1) is green with this patch.

Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/ --- (Updated May 6, 2016, 12:36 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/#review131978 --- Ship it! Master (f25a4b1) is green with this patch.

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review131981 --- I put some effort into to supporting feathered RBs, you can put

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/ --- (Updated May 6, 2016, 1:58 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-05 Thread Maxim Khutornenko
> On May 6, 2016, 1:54 a.m., John Sirois wrote: > > I put some effort into to supporting feathered RBs, you can put 46997 in > > the `depends on` field and the AuroraBot will apply its diff 1st, then this > > diff on top... currently only works for 1 parent. Aha, thanks for the pointer! -

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

2016-05-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review131984 --- Ship it! Master (f25a4b1) is green with this patch.