Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/ --- (Updated May 25, 2016, 3:58 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-25 Thread Maxim Khutornenko
> On May 25, 2016, 6:19 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/js/filters.js, lines 97-99 > > > > > > In https://reviews.apache.org/r/47809/ you call this `"CPUs"` with a > > unit of `"core(

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/ --- (Updated May 25, 2016, 4:12 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134779 --- Master (9f6a660) is red with this patch. ./build-support/jenkins

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
> On May 25, 2016, 6:15 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 725 > > > > > > The `if r.resource_type.display_unit else ""` expression seems to be > > unused given that

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134780 --- @ReviewBot retry - Maxim Khutornenko On May 25, 2016, 3:58 p.m.

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/#review134781 --- Master (9f6a660) is green with this patch. ./build-support/jenki

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134783 --- Ship it! Master (9f6a660) is green with this patch. ./build-s

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review134790 --- Ship it! Ship It! - Joshua Cohen On May 25, 2016, 4:14 p.m.,

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134802 --- Ship it! Looks good to me in general. Below is not a blocker if

Review Request 47846: Removing requestedPorts usage from the UI

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47846/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
> On May 25, 2016, 6:36 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/admin/admin.py, line 225 > > > > > > We could have the same problem here (and in `get_quota_str` further > > down) as we have below

Re: Review Request 47846: Removing requestedPorts usage from the UI

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47846/#review134812 --- Master (3cf6e4e) is green with this patch. ./build-support/jenki

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/ --- (Updated May 25, 2016, 7:41 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134811 --- LGTM. Only minor comments/questions left. src/main/java/org/apac

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134816 --- Ship it! Master (3cf6e4e) is green with this patch. ./build-s

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134825 --- Ship it! Ship It! - Joshua Cohen On May 25, 2016, 7:41 p.m.,

Re: Review Request 47846: Removing requestedPorts usage from the UI

2016-05-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47846/#review134824 --- Ship it! Ship It! - Joshua Cohen On May 25, 2016, 7:30 p.m.,

Review Request 47853: Isolate the executor's filesystem from the task's.

2016-05-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- Review request for Aurora, Maxim Khutornenko and Stephan Erb. Repository: auror

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review134845 --- Ship it! Master (d521dcd) is green with this patch. ./build-s

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

2016-05-25 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47697/#review134854 --- @ReviewBot retry - Stephan Erb On May 24, 2016, 10:44 a.m., Chr

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-25 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review134856 --- Ship it! Ship It! - Stephan Erb On May 25, 2016, 6:14 p.m.,

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47697/#review134857 --- Master (d521dcd) is green with this patch. ./build-support/jenki

Review Request 47869: Adding support for GPU resource

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: aurora D

Re: Review Request 47869: Adding support for GPU resource

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review134895 --- Ship it! Master (32a8a07) is green with this patch. ./build-s