Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48211/#review136069 --- Thanks for noticing! docs/features/containers.md (line 13)

Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48211/#review136071 --- Ship it! Master (edd47d0) is green with this patch.

Review Request 48210: fix container docs example

2016-06-03 Thread Raymond Khalife
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48210/ --- Review request for Aurora. Repository: aurora Description --- fix

Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Raymond Khalife
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48211/ --- (Updated June 3, 2016, 4:07 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 48210: fix container docs example

2016-06-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48210/#review136070 --- Ship it! Master (edd47d0) is green with this patch.

Re: Review Request 48211: fix containers doc example

2016-06-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48211/#review136072 --- Ship it! Ship It! - Stephan Erb On June 3, 2016, 6:07 p.m.,

Review Request 48211: fix containers doc example

2016-06-03 Thread Raymond Khalife
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48211/ --- Review request for Aurora. Repository: aurora Description --- fix

Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48218/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description

Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2016-06-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48216/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1449 and AURORA-1450

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136092 --- Looks good to me in general. Mostly nits below...

Re: Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2016-06-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48216/#review136096 --- Ship it! Ship It! - Joshua Cohen On June 3, 2016, 6:30

Re: Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2016-06-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48216/#review136093 --- Master (692b5d1) is green with this patch.

Re: Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48218/#review136099 --- Ship it! Master (692b5d1) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated June 3, 2016, 10:17 p.m.) Review request for Aurora, Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136144 --- Ship it! Master (692b5d1) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated June 3, 2016, 11:54 p.m.) Review request for Aurora, Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko
> On May 27, 2016, 2 p.m., Stephan Erb wrote: > > Repeating from my previous review: Would be great if you could add > > > > * an entry to the release notes > > * a minimal docs/features/webhooks.md that shows a valid webhook config and > > how a dispatched event would look like. Done. > On

Re: Review Request 48218: Document the logfile locations used in the vagrant box

2016-06-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48218/#review136098 --- Ship it! docs/getting-started/vagrant.md (lines 153 - 154)