Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-20 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- (Updated July 20, 2016, 9:26 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142959 --- Ship it! Master (e67c6a7) is green with this patch. ./build-s

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 13 > > > > > > Maybe add here explicitly that `production` is deprecated and that > > people should use `tier='preferred'` instead. > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/cli/context.py, line 143 > > > > > > Side stepping the `get_config` factory and re-creating the > > `AnnotatedAuroraConfig`

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > src/test/python/apache/aurora/client/cli/test_cron.py, line 111 > > > > > > As an example of many similar test changes: > > > > The additional mock calls

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142990 --- Ship it! I'm not super bothered by the double labels, so I'm ok

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-20 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- (Updated July 20, 2016, 12:28 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-20 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated July 21, 2016, 3:35 a.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-20 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated July 21, 2016, 3:37 a.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review143052 --- Ship it! Master (e67c6a7) is green with this patch. ./build-s