Re: Review Request 54439: Add support for an mttu metric (median time to updated)

> On Dec. 7, 2016, 6:28 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 200-202 > > > > > > Why do we only sample active updates, seems like we could

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

> On Dec. 7, 2016, 8:42 a.m., Mehrdad Nurolahzade wrote: > > A general side note: SLA metrics calculation is currently the most > > expensive cpu-bound operation handled by the scheduler (it can take as much > > as 50% master cpu cycles). The calculators seem like a good fit for > >

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158575 --- Please remove me from the reviewers list. I have no time to

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158567 --- Ship it! LGTM. Please also add an entry to the changelog. -

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158573 --- LGTM. Please add: * a changelog entry * a short section to our

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158593 --- Master (f5749ce) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- (Updated Dec. 8, 2016, 2:24 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- (Updated Dec. 8, 2016, 3:06 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158597 --- Master (f5749ce) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158601 --- Does anyone know how to get the test reports from jenkins or have

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158626 --- Ship it! Ship It! - John Sirois On Dec. 8, 2016, 7:15 p.m.,

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158627 --- Master (f5749ce) is red with this patch.

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

> On Dec. 9, 2016, 2:22 a.m., Zameer Manji wrote: > > build-support/thrift/prepare_binary.sh, line 3 > > > > > > To be consistent can you do `set -o xtrace`? TIL - Joshua

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/ --- (Updated Dec. 9, 2016, 2:30 a.m.) Review request for Aurora and Santhosh Kumar

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158630 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Dec. 8,

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158629 --- Master (f5749ce) is red with this patch.

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

> On Dec. 8, 2016, 7:37 p.m., Aurora ReviewBot wrote: > > Master (f5749ce) is red with this patch. > > ./build-support/jenkins/build.sh > > > > You are using pip version 8.1.2, however version 9.0.1 is available. > > You should consider upgrading via the 'pip install --upgrade pip' command. >

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158632 --- build-support/thrift/prepare_binary.sh (line 29)

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > > > > > aha - popd on linux echos the dirstack - presumably it does not do this > > on osx... so needs a

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > > > > > aha - popd on linux echos the dirstack - presumably it does not do this > > on osx... so needs a

Review Request 54567: Fixup prepare_binary.sh to work under modern bash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54567/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description

Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/ --- Review request for Aurora and Santhosh Kumar Shanmugham. Repository: aurora

Review Request 54569: Change back to thrift directory silently after executing pants command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54569/ --- Review request for Aurora and John Sirois. Repository: aurora Description

Re: Review Request 54567: Fixup prepare_binary.sh to work under modern bash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54567/#review158638 --- Ship it! Ship It! - Joshua Cohen On Dec. 9, 2016, 3:58