-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/
-----------------------------------------------------------

(Updated Dec. 8, 2016, 3:06 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and 
Stephan Erb.


Changes
-------

Appease PMD


Bugs: AURORA-1669
    https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
-------

As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
leadership if the ZK connection is lost or if there is a timeout. This is not
compatible with the commons based implementation which would only abdicate
leadership if the ZK session timeout occurred.

This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
custom listener that only loses leadership if a connection loss occurs.


Diffs (updated)
-----

  
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
 50acaeba82e163f8f2970a264cbd889c9eb3b5ed 
  
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
 c378172c850aafe0a9381552b5067277b40dbfab 
  
src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
 a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 
  
src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
 6ea49b0c690d288ff59d1d4798144bfa2d153d3a 

Diff: https://reviews.apache.org/r/54288/diff/


Testing
-------


Thanks,

Zameer Manji

Reply via email to