Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63337/ --- (Updated Oct. 27, 2017, 5:01 p.m.) Review request for Aurora and David

Re: Review Request 63364: Revert role searching in UI to old behavior

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63364/#review189442 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 4:42

Re: Review Request 63364: Revert role searching in UI to old behavior

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63364/#review189446 --- Ship it! Master (5a26c8b) is green with this patch.

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63337/#review189447 --- Master (5a26c8b) is red with this patch.

Review Request 63364: Revert role searching in UI to old behavior

2017-10-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63364/ --- Review request for Aurora, Kai Huang and Reza Motamedi. Repository: aurora

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63337/#review189465 --- @ReviewBot retry - Reza Motamedi On Oct. 27, 2017, 5:01 p.m.,

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63337/#review189466 --- Master (5a26c8b) is red with this patch.

Review Request 63373: Reduce white-space on role and env pages

2017-10-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63373/ --- Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan

Review Request 63374: Revert to old Job Page tab names and add counts

2017-10-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63374/ --- Review request for Aurora, Kai Huang and Reza Motamedi. Repository: aurora

Re: Review Request 63374: Revert to old Job Page tab names and add counts

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63374/#review189469 --- Master (5a26c8b) is red with this patch.

Re: Review Request 63373: Reduce white-space on role and env pages

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63373/#review189470 --- Master (5a26c8b) is red with this patch.

Re: Review Request 63374: Revert to old Job Page tab names and add counts

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63374/#review189472 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 7:48

Review Request 63375: Add resource units to config summary

2017-10-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63375/ --- Review request for Aurora, Kai Huang and Reza Motamedi. Repository: aurora

Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63375/#review189473 --- Master (d6bc8eb) is red with this patch.

Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63375/#review189480 --- Ship it! Ship It! - Kai Huang On Oct. 27, 2017, 7:58 p.m.,

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Joshua Cohen
> On Oct. 28, 2017, 12:08 a.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > > Lines 303-305 (patched) > > > > > > Does Mesos send any other important information

Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63383/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63383/#review189498 --- Ship it! Master (f6c40a2) is green with this patch.

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63383/#review189497 --- Fix it, then Ship it! One small question, but overall LGTM.

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

2017-10-27 Thread Bill Farner
> On Oct. 27, 2017, 5:08 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > > Lines 303-305 (patched) > > > > > > Does Mesos send any other important information

Re: Review Request 63374: Revert to old Job Page tab names and add counts

2017-10-27 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63374/#review189477 --- Ship it! Ship It! - Kai Huang On Oct. 27, 2017, 7:48 p.m.,

Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call

2017-10-27 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/ --- (Updated Oct. 27, 2017, 9:13 p.m.) Review request for Aurora, David

Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/#review189485 --- Master (62e7d23) is red with this patch.

Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call

2017-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/#review189487 --- Master (62e7d23) is red with this patch.

Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call

2017-10-27 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/ --- (Updated Oct. 27, 2017, 9:27 p.m.) Review request for Aurora, David

Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call

2017-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/#review189482 --- Ship it! Ship It! - Bill Farner On Oct. 27, 2017, 2:13

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189488 ---

Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63375/#review189483 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 7:58