Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-11 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/ --- (Updated Dec. 11, 2017, 11:13 a.m.) Review request for Aurora, David

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193430 --- I have filed https://issues.apache.org/jira/browse/AURORA-1961 to

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193431 --- I have filed https://issues.apache.org/jira/browse/AURORA-1961 to

Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/ --- Review request for Aurora. Repository: aurora Description --- Spotbugs

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193420 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m.,

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193477 --- Ship it! build-support/jenkins/review_feedback.py Line 178

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193447 --- The script is run from master so it will only work once comitted.

Review Request 64519: Add a test to detect incompatible storage changes

2017-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64519/ --- Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.

Re: Review Request 64519: Add a test to detect incompatible storage changes

2017-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64519/#review193479 --- Reviewer notes

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

2017-12-11 Thread Bill Farner
> On Dec. 11, 2017, 6:57 p.m., Bill Farner wrote: > > I should have looked more closely at the last patch, and when preparing my > > patch before that. This test is bound to be flaky since there's nothing > > ensuring a happens-before releationship between issuing the request and > >

Review Request 64523: Attempt #2 to fix flaky Webhook test

2017-12-11 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1961

Re: Review Request 64519: Add a test to detect incompatible storage changes

2017-12-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64519/#review193482 --- Ship it! Master (ef24c2c) is green with this patch.

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

2017-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/#review193491 --- I should have looked more closely at the last patch, and when

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-11 Thread John Sirois
> On Dec. 11, 2017, 12:38 p.m., Stephan Erb wrote: > > I have filed https://issues.apache.org/jira/browse/AURORA-1961 to address > > the flaky build. Thanks Stephan. - John --- This is an automatically generated e-mail. To reply,

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

2017-12-11 Thread Bill Farner
> On Dec. 11, 2017, 6:57 p.m., Bill Farner wrote: > > I should have looked more closely at the last patch, and when preparing my > > patch before that. This test is bound to be flaky since there's nothing > > ensuring a happens-before releationship between issuing the request and > >

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193499 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m.,

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

2017-12-11 Thread Jordan Ly
> On Dec. 12, 2017, 2:57 a.m., Bill Farner wrote: > > I should have looked more closely at the last patch, and when preparing my > > patch before that. This test is bound to be flaky since there's nothing > > ensuring a happens-before releationship between issuing the request and > >