Re: Review Request 32553: Fix missing hooked api dependencies.

2015-03-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32553/#review77961 --- Ship it! Ship It! - Zameer Manji On March 26, 2015, 3:28 p.m

Re: Review Request 33366: Fix the path to download stdout/stderr

2015-04-21 Thread Zameer Manji
/test_file_browser.py https://reviews.apache.org/r/33366/#comment131262 Please remove `int(x)` and replace it with `x` everywhere in this file. - Zameer Manji On April 21, 2015, 11:53 a.m., Bhuvan Arumugam wrote: --- This is an automatically

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji
May 7, 2015, 4:58 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1239 https://issues.apache.org/jira/browse/AURORA-1239 Repository: aurora Description --- Add update watch and update start --watch flag. Diffs - src/main

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji
://reviews.apache.org/r/33959/#comment133841 Shouldn't we abort if the response is not OK? Also how does this work when the scheduler fails over? - Zameer Manji On May 7, 2015, 6:04 p.m., Bill Farner wrote: --- This is an automatically

Re: Review Request 33967: AURORA-1312: Fix missing license headers in new files added since 0.7.0

2015-05-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33967/#review82965 --- Ship it! Ship It! - Zameer Manji On May 7, 2015, 7:41 p.m

Re: Review Request 33955: Invoke pip as a python module rather than directly.

2015-05-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33955/#review82900 --- Ship it! Ship It! - Zameer Manji On May 7, 2015, 1:50 p.m

Re: Review Request 33920: Set verbose=False in the client to squelch noisy ZooKeeper logging.

2015-05-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33920/#review82765 --- Ship it! Ship It! - Zameer Manji On May 6, 2015, 4:06 p.m

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-10 Thread Zameer Manji
On May 10, 2015, 7:53 p.m., Joe Smith wrote: packaging/rpm/Makefile, line 15 https://reviews.apache.org/r/33778/diff/3/?file=952806#file952806line15 My hunch is we should grab this from either the requirements.txt or the java dep, vs. specifying it here +1. We don't need more

Re: Review Request 33924: Adding missing API hook support in kill commands.

2015-05-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33924/#review83072 --- Ship it! Ship It! - Zameer Manji On May 6, 2015, 6:28 p.m

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review83089 --- Ship it! Ship It! - Zameer Manji On May 8, 2015, 1:57 p.m

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-05-18 Thread Zameer Manji
On May 15, 2015, 6:17 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/config/__init__.py, lines 255-257 https://reviews.apache.org/r/34300/diff/1/?file=961839#file961839line255 Delete this property entirely rather than return a dummy value? Presumably anything accessing

Review Request 34372: Place api_util.py inside a `pants_library` target.

2015-05-18 Thread Zameer Manji
/python:: Thanks, Zameer Manji

Re: Review Request 33200: Require non-default primitive values in StorageEntityUtil, extract a task factory utility.

2015-04-16 Thread Zameer Manji
TestTaskUtil replaces a lot of the custom fixtures used in different test cases. I think it counts for a non trival portion of the diff. - Zameer Manji On April 14, 2015, 5:04 p.m., Bill Farner wrote: --- This is an automatically generated e-mail

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-16 Thread Zameer Manji
/preemptor/PendingTaskProcessor.java https://reviews.apache.org/r/32597/#comment130285 Don't we want `pendingGroups.remove(group)`? - Zameer Manji On April 15, 2015, 6:39 p.m., Maxim Khutornenko wrote: --- This is an automatically generated

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79833 --- Ship it! Ship It! - Zameer Manji On April 11, 2015, 2:52 p.m

Review Request 32993: Revert Bump pants version to 0.0.32.

2015-04-08 Thread Zameer Manji
78bae5bb6d254d014e35be0b828497f1509d80bd Diff: https://reviews.apache.org/r/32993/diff/ Testing --- ./pants --print-exception-stacktrace test.pytest --no-fast src/test/python/:: Thanks, Zameer Manji

Re: Review Request 33029: Use installDist instead of installApp.

2015-04-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33029/#review79557 --- Ship it! Ship It! - Zameer Manji On April 9, 2015, 12:02 p.m

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Zameer Manji
. - Zameer Manji On April 14, 2015, 11:17 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-06 Thread Zameer Manji
and Zameer Manji. Bugs: AURORA-1219 https://issues.apache.org/jira/browse/AURORA-1219 Repository: aurora Description --- This is addressing the preemption efficiency loss due to making preemptor async. Summary: - Implemented fair task processing by evaluating pending

Re: Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Zameer Manji
/#comment135666 perhaps we should call `executor.shutdownNow` here? src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java https://reviews.apache.org/r/34440/#comment135670 How is this related to this diff? - Zameer Manji On May 19, 2015, 3:50 p.m., Maxim

Re: Review Request 34449: Validating INSTANCES_SPEC_ARGUMENT option range

2015-05-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34449/#review84428 --- Ship it! Ship It! - Zameer Manji On May 19, 2015, 5:27 p.m

Re: Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Zameer Manji
On May 19, 2015, 4:48 p.m., Zameer Manji wrote: Does it make sense for the reconciler to run in parallel with the GC executor mechanism? It seems fine to me, but I would like some re-assurance here. Maxim Khutornenko wrote: GC executor is not adding anything when task

Re: Review Request 34440: Implementing task reconciler.

2015-05-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84442 --- Ship it! Ship It! - Zameer Manji On May 19, 2015, 6:34 p.m

Re: Review Request 34967: Use TaskStatus Reason to set memory limit message.

2015-06-02 Thread Zameer Manji
/UserTaskLauncherTest.java fe2fc954350b42487151fc820ebad22a41aeb039 Diff: https://reviews.apache.org/r/34967/diff/ Testing --- ./gradlew test -Pq Thanks, Zameer Manji

Review Request 34967: Use TaskStatus Reason to set memory limit message.

2015-06-02 Thread Zameer Manji
://reviews.apache.org/r/34967/diff/ Testing --- ./gradlew test -Pq Thanks, Zameer Manji

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Zameer Manji
line of the review? Also, would you mind adding the testcase you described to the test? This way regressions can be caught. - Zameer Manji On June 22, 2015, 2:39 p.m., Michael Leinartas wrote: --- This is an automatically generated e

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88878 --- Ship it! Ship It! - Zameer Manji On June 22, 2015, 4:01 p.m

Re: Review Request 35886: Remove static modifier from test case.

2015-06-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35886/#review89411 --- Ship it! Ship It! - Zameer Manji On June 25, 2015, 11:50 a.m

Re: Review Request 35812: Remove enable_legacy_constraints flag.

2015-06-25 Thread Zameer Manji
., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/ --- (Updated June 25, 2015, 5:07 p.m.) Review

Re: Review Request 35812: Remove enable_legacy_constraints flag.

2015-06-25 Thread Zameer Manji
--- On June 25, 2015, 5:07 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/ --- (Updated June 25

Re: Review Request 35812: Remove enable_legacy_constraints flag.

2015-06-25 Thread Zameer Manji
71b09b1fddc5faa7960ade43929cb57eec3243dd Diff: https://reviews.apache.org/r/35812/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Zameer Manji
/CommandUtilTest.java (line 69) https://reviews.apache.org/r/35760/#comment141516 We can remove this test now that the gc executor is gone. - Zameer Manji On June 22, 2015, 6:50 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/#review89527 --- Ship it! - Zameer Manji On June 26, 2015, 10:50 a.m., Bill

Review Request 35812: Remove enable_legacy_constraints flag.

2015-06-23 Thread Zameer Manji
38ef412a6d29dfef7b305e00cf44522818303965 Diff: https://reviews.apache.org/r/35812/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-26 Thread Zameer Manji
/ Testing --- ./rbt post -o Thanks, Zameer Manji

Re: Review Request 35483: Removing deprecated JobUpdateSummary fields.

2015-06-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35483/#review88010 --- Ship it! Ship It! - Zameer Manji On June 15, 2015, 5:27 p.m

Re: Review Request 34967: Use TaskStatus Reason to set memory limit message.

2015-06-03 Thread Zameer Manji
/UserTaskLauncherTest.java fe2fc954350b42487151fc820ebad22a41aeb039 Diff: https://reviews.apache.org/r/34967/diff/ Testing --- ./gradlew test -Pq Thanks, Zameer Manji

Re: Review Request 34967: Use TaskStatus Reason to set memory limit message.

2015-06-03 Thread Zameer Manji
--- On June 2, 2015, 6:11 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34967

Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/#review85441 --- Ship it! Ship It! - Zameer Manji On May 27, 2015, 1:52 p.m

Re: Review Request 34827: Moving checkpoint root into the executor sandbox.

2015-05-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34827/#review85789 --- Ship it! Ship It! - Zameer Manji On May 29, 2015, 12:54 p.m

Re: Review Request 35928: Avoid unintentional use of TaskStatus.Reason default value.

2015-07-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35928/#review90073 --- Ship it! Ship It! - Zameer Manji On July 1, 2015, 10:30 a.m

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-29 Thread Zameer Manji
. Perhaps the label keys should be prefixed? - Zameer Manji On June 28, 2015, 1:44 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Zameer Manji
things: 1. Remove wfarner from this review as currently he is on vacation. I suggest adding kevints or jcohen. 2. Assign the ticket linked to this review to yourself and link to this review in the comments of the ticket. 3. Confirm the e2e tests work with this change. - Zameer Manji On May 21

Re: Review Request 37593: Modifying resource counters to support revocable resources.

2015-08-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37593/#review95899 --- Ship it! Ship It! - Zameer Manji On Aug. 18, 2015, 3:58 p.m

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Zameer Manji
--- On Aug. 20, 2015, 6:04 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 21, 2015, 11:02 a.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Zameer Manji
., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 21, 2015, 11:02 a.m.) Review request

Re: Review Request 37663: Adding REVOCABLE_RESOURCES FrameworkInfo capability.

2015-08-20 Thread Zameer Manji
this flag. src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java (line 80) https://reviews.apache.org/r/37663/#comment151213 You might want to put a warning comment about the consequences of enabling this and point to MESOS-703. - Zameer Manji On Aug. 20, 2015, 5

Re: Review Request 37666: Import of Twitter Commons.

2015-08-20 Thread Zameer Manji
in build.gradle. - Zameer Manji On Aug. 20, 2015, 6:04 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666

Review Request 37666: Import of Twitter Commons.

2015-08-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- Review request for Aurora, Jake Farrell, Kevin Sweeney, Maxim Khutornenko, and

Re: Review Request 37624: Updating preemptor to account for revocable offers/tasks

2015-08-20 Thread Zameer Manji
reviewbot. - Zameer Manji On Aug. 19, 2015, 4:49 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37624

Re: Review Request 36015: Fix terminology in cron docs.

2015-06-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36015/#review89787 --- Ship it! Ship It! - Zameer Manji On June 29, 2015, 12:38 p.m

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Zameer Manji
2a2b499905a788eb59f5824bc66b487f91e838f1 Diff: https://reviews.apache.org/r/35954/diff/ Testing --- ./rbt post -o Thanks, Zameer Manji

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Zameer Manji
--- On June 29, 2015, 1:59 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Zameer Manji
2a2b499905a788eb59f5824bc66b487f91e838f1 Diff: https://reviews.apache.org/r/35954/diff/ Testing --- ./rbt post -o Thanks, Zameer Manji

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89961 --- Ship it! LGTM. - Zameer Manji On June 30, 2015, 12:36 p.m

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
) https://reviews.apache.org/r/37137/#comment148852 My lack of angular knowledge is showing: where is the 'inProgress' expression defined? - Zameer Manji On Aug. 5, 2015, 1:28 p.m., Joshua Cohen wrote: --- This is an automatically

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
On Aug. 5, 2015, 1:49 p.m., Zameer Manji wrote: src/main/resources/scheduler/assets/css/app.css, line 436 https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436 If we are going to add the -webkit prefix then I think we should do the same for -moz. Otherwise I

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94308 --- Ship it! Ship It! - Zameer Manji On Aug. 5, 2015, 1:28 p.m

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
On Aug. 5, 2015, 1:49 p.m., Zameer Manji wrote: src/main/resources/scheduler/assets/css/app.css, line 436 https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436 If we are going to add the -webkit prefix then I think we should do the same for -moz. Otherwise I

Re: Review Request 37001: Centralizing offer/task matching in TaskAssigner.

2015-08-03 Thread Zameer Manji
/TaskScheduler.java (line 101) https://reviews.apache.org/r/37001/#comment148359 nit: Was it needed to flip the BiCache type here? If not, it would be nice not to do it to minimize the diff. - Zameer Manji On July 31, 2015, 4:03 p.m., Maxim Khutornenko wrote

Re: Review Request 37139: Resources: moving calculation methods from Resources

2015-08-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37139/#review94440 --- Ship it! Ship It! - Zameer Manji On Aug. 5, 2015, 12:48 p.m

Re: Review Request 37206: Fixing slave/task reservation check.

2015-08-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37206/#review94560 --- Ship it! Ship It! - Zameer Manji On Aug. 6, 2015, 9:12 p.m

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

2015-08-13 Thread Zameer Manji
/ResourceSlot.java https://reviews.apache.org/r/37153/#comment150253 If we are going to keep this class in the long term since it is now more than a type that captures executor overhead, do you want to close that ticket? - Zameer Manji On Aug. 13, 2015, 2:46 p.m., Maxim Khutornenko wrote

Re: Review Request 37447: Making scheduler loop continue after mismatch.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37447/#review95334 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 2:25 p.m

Re: Review Request 37455: Moving ResourceAggregates into scheduler package.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37455/#review95361 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 4:53 p.m

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/#review95342 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 2:46 p.m

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

2015-07-22 Thread Zameer Manji
this review by linking to a ticket (bugs field) and adding myself (zmanji) under the People field? - Zameer Manji On July 22, 2015, 11:06 a.m., Zane Silver wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

2015-07-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36697/#review92654 --- Ship it! Ship It! - Zameer Manji On July 22, 2015, 11:29 a.m

Re: Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

2015-07-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36709/#review92661 --- Ship it! Nice find. - Zameer Manji On July 22, 2015, 3:13 p.m

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

2015-07-22 Thread Zameer Manji
. - Zameer Manji On July 22, 2015, 11:29 a.m., Zane Silver wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36697/ --- (Updated July

Re: Review Request 36711: Remove all public static com.google.common.base.Functions

2015-07-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36711/#review92681 --- Ship it! Ship It! - Zameer Manji On July 22, 2015, 4:18 p.m

Re: Review Request 36511: Removes version on virtual pacakge in debian control

2015-07-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36511/#review91788 --- Ship it! Ship It! - Zameer Manji On July 15, 2015, 10:50 a.m

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
On July 13, 2015, 3:04 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java, line 14 https://reviews.apache.org/r/36407/diff/1/?file=1008771#file1008771line14 Why not move this class to org.apache.aurora.util? Nothing about

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
On July 13, 2015, 3:04 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java, line 40 https://reviews.apache.org/r/36407/diff/1/?file=1008765#file1008765line40 Some db view classes provide methods to convert to the immutable

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36407/#review91559 --- Ship it! Ship It! - Zameer Manji On July 10, 2015, 3:47 p.m

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
to db views. - Zameer Manji On July 10, 2015, 3:47 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36407

Re: Review Request 36387: Fix JDBC URL.

2015-07-13 Thread Zameer Manji
this issue? - Zameer Manji On July 9, 2015, 10:31 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36387

Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.

2015-07-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/#review91653 --- Ship it! Ship It! - Zameer Manji On July 14, 2015, 10:27 a.m

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96377 --- Ship it! Ship It! - Zameer Manji On Aug. 25, 2015, 8:01 a.m

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
to non-prod behavior. This change fixes the oversight and delivers on naming expectations. Nothing else in the tutorial has to change. Zameer Manji wrote: I don't mind this change, but it does feel out of place in the diff. Bill Farner wrote: Doesn't this mean, though, that quota needs

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 24, 2015, 10:32 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1414 https://issues.apache.org/jira/browse/AURORA

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
, 2015, 10:32 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1414 https://issues.apache.org/jira/browse/AURORA-1414 Repository: aurora Description --- Added support for 'tier' in schema and thrift. Diffs - api/src/main

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
the ticket id here. src/main/python/apache/aurora/client/config.py (line 60) https://reviews.apache.org/r/37719/#comment151522 Please create a ticket for this task. You could also repurpose https://issues.apache.org/jira/browse/AURORA-319 - Zameer Manji On Aug. 24, 2015, 10:32 a.m., Maxim

Re: Review Request 37666: Import of Twitter Commons.

2015-08-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 4:54 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 37666: Import of Twitter Commons.

2015-08-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 5:03 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 37666: Import of Twitter Commons.

2015-08-24 Thread Zameer Manji
On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote: It would be great to preserve all commit history with this import. Any chance you could follow the sapling split procedure? It's a bit involved but pretty well documented here: https://github.com/jsirois/sapling Zameer Manji

Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Zameer Manji
/aurora/scheduler/SchedulerServicesModule.java 7b110b9698440b7e09b777afe430944845530eee Diff: https://reviews.apache.org/r/39631/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-24 Thread Zameer Manji
d7d649dc8aaacd98772183fa1429ef8fc84fa20a src/main/python/apache/aurora/tools/thermos_observer.py 82de0a14b3de2bf3d1b7282fe7dc9fc185d7 Diff: https://reviews.apache.org/r/39629/diff/ Testing --- e2e tests passed Thanks, Zameer Manji

Review Request 39630: Explicitly declare FindBugs version and effort level.

2015-10-24 Thread Zameer Manji
--- Explicitly declare FindBugs version and effort level. Diffs - build.gradle 6c7644ecad6e726cfaa82b6aabc005d8a3b243d3 Diff: https://reviews.apache.org/r/39630/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji

Re: Review Request 39563: Ignore serverInfo on the client side.

2015-10-22 Thread Zameer Manji
/r/39563/ > --- > > (Updated Oct. 22, 2015, 2:35 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1522 > https://issues.apache.org/jira/browse/AURORA-1522 >

Re: Review Request 39572: Remove callable check.

2015-10-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39572/#review103688 --- Ship it! Ship It! - Zameer Manji On Oct. 22, 2015, 4:42 p.m

Re: Review Request 39563: Ignore serverInfo on the client side.

2015-10-22 Thread Zameer Manji
this is the way to go so long as we also start the deprecation process. - Zameer Manji On Oct. 22, 2015, 2:35 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-26 Thread Zameer Manji
/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-26 Thread Zameer Manji
Thanks, Zameer Manji

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-26 Thread Zameer Manji
build -Pq Thanks, Zameer Manji

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Zameer Manji
/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java a1ac922d471013779710e02c0c9ca9f84b506807 Diff: https://reviews.apache.org/r/39670/diff/ Testing --- ./gradlew build -Pq If the approach is good, I can update this with benchmark information. Thanks, Zameer Manji

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Zameer Manji
to reflect this. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104295 --- On Oct. 27, 2015, 9:

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
to use the built in pants checkstyle? - Zameer Manji On Oct. 29, 2015, 3:05 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104186 --- Ship it! Ship It! - Zameer Manji On Oct. 27, 2015, 10:44 a.m

  1   2   3   4   5   6   7   8   9   >