/test_file_browser.py
https://reviews.apache.org/r/33366/#comment131262
Please remove `int(x)` and replace it with `x` everywhere in this file.
- Zameer Manji
On April 21, 2015, 11:53 a.m., Bhuvan Arumugam wrote:
---
This is an automatically
May 7, 2015, 4:58 p.m.)
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239
Repository: aurora
Description
---
Add update watch and update start --watch flag.
Diffs
-
src/main
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33967/#review82965
---
Ship it!
Ship It!
- Zameer Manji
On May 7, 2015, 7:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/#review82765
---
Ship it!
Ship It!
- Zameer Manji
On May 6, 2015, 4:06 p.m
On May 10, 2015, 7:53 p.m., Joe Smith wrote:
packaging/rpm/Makefile, line 15
https://reviews.apache.org/r/33778/diff/3/?file=952806#file952806line15
My hunch is we should grab this from either the requirements.txt or the
java dep, vs. specifying it here
+1. We don't need more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/#review83072
---
Ship it!
Ship It!
- Zameer Manji
On May 6, 2015, 6:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83089
---
Ship it!
Ship It!
- Zameer Manji
On May 8, 2015, 1:57 p.m
/python::
Thanks,
Zameer Manji
TestTaskUtil replaces a lot of
the custom fixtures used in different test cases. I think it counts for a non
trival portion of the diff.
- Zameer Manji
On April 14, 2015, 5:04 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail
/preemptor/PendingTaskProcessor.java
https://reviews.apache.org/r/32597/#comment130285
Don't we want `pendingGroups.remove(group)`?
- Zameer Manji
On April 15, 2015, 6:39 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated
78bae5bb6d254d014e35be0b828497f1509d80bd
Diff: https://reviews.apache.org/r/32993/diff/
Testing
---
./pants --print-exception-stacktrace test.pytest --no-fast src/test/python/::
Thanks,
Zameer Manji
/#comment135666
perhaps we should call `executor.shutdownNow` here?
src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
https://reviews.apache.org/r/34440/#comment135670
How is this related to this diff?
- Zameer Manji
On May 19, 2015, 3:50 p.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34449/#review84428
---
Ship it!
Ship It!
- Zameer Manji
On May 19, 2015, 5:27 p.m
On May 19, 2015, 4:48 p.m., Zameer Manji wrote:
Does it make sense for the reconciler to run in parallel with the GC
executor mechanism? It seems fine to me, but I would like some re-assurance
here.
Maxim Khutornenko wrote:
GC executor is not adding anything when task
/UserTaskLauncherTest.java
fe2fc954350b42487151fc820ebad22a41aeb039
Diff: https://reviews.apache.org/r/34967/diff/
Testing
---
./gradlew test -Pq
Thanks,
Zameer Manji
://reviews.apache.org/r/34967/diff/
Testing
---
./gradlew test -Pq
Thanks,
Zameer Manji
line of the
review?
Also, would you mind adding the testcase you described to the test? This way
regressions can be caught.
- Zameer Manji
On June 22, 2015, 2:39 p.m., Michael Leinartas wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35886/#review89411
---
Ship it!
Ship It!
- Zameer Manji
On June 25, 2015, 11:50 a.m
., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---
(Updated June 25, 2015, 5:07 p.m.)
Review
---
On June 25, 2015, 5:07 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---
(Updated June 25
71b09b1fddc5faa7960ade43929cb57eec3243dd
Diff: https://reviews.apache.org/r/35812/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
38ef412a6d29dfef7b305e00cf44522818303965
Diff: https://reviews.apache.org/r/35812/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
/
Testing
---
./rbt post -o
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88010
---
Ship it!
Ship It!
- Zameer Manji
On June 15, 2015, 5:27 p.m
/UserTaskLauncherTest.java
fe2fc954350b42487151fc820ebad22a41aeb039
Diff: https://reviews.apache.org/r/34967/diff/
Testing
---
./gradlew test -Pq
Thanks,
Zameer Manji
---
On June 2, 2015, 6:11 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34967
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85441
---
Ship it!
Ship It!
- Zameer Manji
On May 27, 2015, 1:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34827/#review85789
---
Ship it!
Ship It!
- Zameer Manji
On May 29, 2015, 12:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35928/#review90073
---
Ship it!
Ship It!
- Zameer Manji
On July 1, 2015, 10:30 a.m
things:
1. Remove wfarner from this review as currently he is on vacation. I suggest
adding kevints or jcohen.
2. Assign the ticket linked to this review to yourself and link to this review
in the comments of the ticket.
3. Confirm the e2e tests work with this change.
- Zameer Manji
On May 21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37593/#review95899
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 18, 2015, 3:58 p.m
---
On Aug. 20, 2015, 6:04 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 21, 2015, 11:02 a.m.)
Review request for Aurora, Jake Farrell,
., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 21, 2015, 11:02 a.m.)
Review request
in build.gradle.
- Zameer Manji
On Aug. 20, 2015, 6:04 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
Review request for Aurora, Jake Farrell, Kevin Sweeney, Maxim Khutornenko, and
reviewbot.
- Zameer Manji
On Aug. 19, 2015, 4:49 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37624
---
On June 29, 2015, 1:59 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35954
2a2b499905a788eb59f5824bc66b487f91e838f1
Diff: https://reviews.apache.org/r/35954/diff/
Testing
---
./rbt post -o
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89961
---
Ship it!
LGTM.
- Zameer Manji
On June 30, 2015, 12:36 p.m
)
https://reviews.apache.org/r/37137/#comment148852
My lack of angular knowledge is showing: where is the 'inProgress'
expression defined?
- Zameer Manji
On Aug. 5, 2015, 1:28 p.m., Joshua Cohen wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37137/#review94308
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 5, 2015, 1:28 p.m
On Aug. 5, 2015, 1:49 p.m., Zameer Manji wrote:
src/main/resources/scheduler/assets/css/app.css, line 436
https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436
If we are going to add the -webkit prefix then I think we should do the
same for -moz. Otherwise I
/TaskScheduler.java (line
101)
https://reviews.apache.org/r/37001/#comment148359
nit: Was it needed to flip the BiCache type here? If not, it would be nice
not to do it to minimize the diff.
- Zameer Manji
On July 31, 2015, 4:03 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37206/#review94560
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 6, 2015, 9:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/#review95334
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 2:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37455/#review95361
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 4:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37366/#review95342
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 2:46 p.m
this review by linking to a ticket (bugs field) and
adding myself (zmanji) under the People field?
- Zameer Manji
On July 22, 2015, 11:06 a.m., Zane Silver wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/#review92654
---
Ship it!
Ship It!
- Zameer Manji
On July 22, 2015, 11:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36709/#review92661
---
Ship it!
Nice find.
- Zameer Manji
On July 22, 2015, 3:13 p.m
.
- Zameer Manji
On July 22, 2015, 11:29 a.m., Zane Silver wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/
---
(Updated July
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91788
---
Ship it!
Ship It!
- Zameer Manji
On July 15, 2015, 10:50 a.m
On July 13, 2015, 3:04 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java, line
14
https://reviews.apache.org/r/36407/diff/1/?file=1008771#file1008771line14
Why not move this class to org.apache.aurora.util? Nothing about
On July 13, 2015, 3:04 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java,
line 40
https://reviews.apache.org/r/36407/diff/1/?file=1008765#file1008765line40
Some db view classes provide methods to convert to the immutable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36407/#review91559
---
Ship it!
Ship It!
- Zameer Manji
On July 10, 2015, 3:47 p.m
to db views.
- Zameer Manji
On July 10, 2015, 3:47 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36407
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/#review91653
---
Ship it!
Ship It!
- Zameer Manji
On July 14, 2015, 10:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37761/#review96377
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 25, 2015, 8:01 a.m
to non-prod behavior. This change fixes the oversight and delivers
on naming expectations. Nothing else in the tutorial has to change.
Zameer Manji wrote:
I don't mind this change, but it does feel out of place in the diff.
Bill Farner wrote:
Doesn't this mean, though, that quota needs
e-mail. To reply, visit:
https://reviews.apache.org/r/37719/
---
(Updated Aug. 24, 2015, 10:32 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1414
https://issues.apache.org/jira/browse/AURORA
the ticket id
here.
src/main/python/apache/aurora/client/config.py (line 60)
https://reviews.apache.org/r/37719/#comment151522
Please create a ticket for this task. You could also repurpose
https://issues.apache.org/jira/browse/AURORA-319
- Zameer Manji
On Aug. 24, 2015, 10:32 a.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 24, 2015, 4:54 p.m.)
Review request for Aurora, Jake Farrell,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 24, 2015, 5:03 p.m.)
Review request for Aurora, Jake Farrell,
On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote:
It would be great to preserve all commit history with this import. Any
chance you could follow the sapling split procedure? It's a bit involved
but pretty well documented here: https://github.com/jsirois/sapling
Zameer Manji
/aurora/scheduler/SchedulerServicesModule.java
7b110b9698440b7e09b777afe430944845530eee
Diff: https://reviews.apache.org/r/39631/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
d7d649dc8aaacd98772183fa1429ef8fc84fa20a
src/main/python/apache/aurora/tools/thermos_observer.py
82de0a14b3de2bf3d1b7282fe7dc9fc185d7
Diff: https://reviews.apache.org/r/39629/diff/
Testing
---
e2e tests passed
Thanks,
Zameer Manji
---
Explicitly declare FindBugs version and effort level.
Diffs
-
build.gradle 6c7644ecad6e726cfaa82b6aabc005d8a3b243d3
Diff: https://reviews.apache.org/r/39630/diff/
Testing
---
./gradlew clean build -Pq
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39572/#review103688
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 22, 2015, 4:42 p.m
this is the way to go so long as we
also start the deprecation process.
- Zameer Manji
On Oct. 22, 2015, 2:35 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Thanks,
Zameer Manji
build -Pq
Thanks,
Zameer Manji
/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java
a1ac922d471013779710e02c0c9ca9f84b506807
Diff: https://reviews.apache.org/r/39670/diff/
Testing
---
./gradlew build -Pq
If the approach is good, I can update this with benchmark information.
Thanks,
Zameer Manji
to reflect this.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39670/#review104295
---
On Oct. 27, 2015, 9:
to use the
built in pants checkstyle?
- Zameer Manji
On Oct. 29, 2015, 3:05 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104186
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 27, 2015, 10:44 a.m
To reply, visit:
https://reviews.apache.org/r/39670/#review104115
-------
On Oct. 26, 2015, 4:16 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39629/#review104235
---
@ReviewBot retry
- Zameer Manji
On Oct. 27, 2015, 4:38 p.m
Thanks,
Zameer Manji
this with benchmark information.
Thanks,
Zameer Manji
://reviews.apache.org/r/39631/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review105990
---
Ship it!
Thanks John!
- Zameer Manji
On Nov. 10, 2015, 2:58
a ship because as it stands it
will break the release scripts we have.
- Zameer Manji
On Nov. 10, 2015, 1:50 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/SchedulerMain.java (line 227)
<https://reviews.apache.org/r/40149/#comment164662>
Is there a reason why we are not using Java's URI type to do this sort of
parsing?
- Zameer Manji
On Nov. 10, 2015, 12:42 p.m., Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39958/#review105716
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 4, 2015, 5:26 p.m
> On Nov. 12, 2015, 11:05 a.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a cu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/#review106467
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 13, 2015, 7:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40304/#review106507
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 13, 2015, 10:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40334/#review106712
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 15, 2015, 3:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40320/#review106709
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 14, 2015, 9 a.m
org/r/40310/#comment165447>
Out of curiosity, could we replace isort with this functionality? I like
the idea of collapsing all of that functionality into pants.
- Zameer Manji
On Nov. 16, 2015, 9:30 a.m., John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40204/#review106172
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 11, 2015, 3:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40208/#review106297
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 11, 2015, 3:58 p.m
custom pants
plugin is the way to go here. Historically we have been very bad at upgrading
pants and maintaining it, I'm afraid that if we add a custom plugin here we
won't be able to upgrade pants in the future at all.
- Zameer Manji
On Nov. 12, 2015, 12:54 a.m., John Sirois wrote
/aurora/KEYS
Diffs
-
KEYS dff0fb48f1b0e8a18bc21014cc425d7d48f08c6d
Diff: https://reviews.apache.org/r/40043/diff/
Testing
---
None. Please verify my key is correct.
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39822/#review104787
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 30, 2015, 1:14 p.m
triy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39822/
> ---
>
> (Updated Oct. 30, 2015, 1:14 p.m.)
>
>
> Review request for
and highlight
any API changes we might need to be aware of?
- Zameer Manji
On Oct. 30, 2015, 11:17 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36319/#review90932
---
Ship it!
Ship It!
- Zameer Manji
On July 8, 2015, 10:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36320/#review90938
---
Ship it!
Ship It!
- Zameer Manji
On July 8, 2015, 10:57 a.m
1 - 100 of 731 matches
Mail list logo
