Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/ --- (Updated April 14, 2015, 8 p.m.) Review request for Aurora, Bill Farner and Zam

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
> On April 14, 2015, 7:52 p.m., Zameer Manji wrote: > > I'm a little hazy on the scope of our performance benchmarks, but do they > > cover the changes in this patch? If so I think the commit should include > > benchmark information. Benchmarks will be addressed after the final https://reviews

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review80089 --- Ship it! I'm a little hazy on the scope of our performance benchmar

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review80076 --- Ship it! Master (3b29a4b) is green with this patch. ./build-suppo

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/ --- (Updated April 14, 2015, 6:17 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review80052 --- Ping Zameer. - Maxim Khutornenko On April 14, 2015, 1:09 a.m., Ma

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review79976 --- Ship it! Master (9aab87f) is green with this patch. ./build-suppo

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/ --- (Updated April 14, 2015, 1:09 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-13 Thread Maxim Khutornenko
> On April 9, 2015, 3:06 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, lines > > 251-252 > > > > > > Does this fail if the pending task was deleted? It's probably fi

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review79470 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/TaskSched

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review79085 --- Ship it! Master (6fc7f58) is green with this patch. ./build-suppo