Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 24, 2015, 5:10 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 24, 2015, 5:08 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > build-artifact.sh, line 40 > > > > > > realpath wasn't available in our vanilla Vagrant environment. Perhaps > > add a check and/or apt-get it? > > Bill Fa

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review95270 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 5, 2015, 5:32 p.m.

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > LGTM overall. I don't have enough docker/debian expertise to deliver best > > value though. > > Bill Farner wrote: > If you are not willing to give a ship, can you please tap someone who you > would be more comfortable with giving

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > build-artifact.sh, line 40 > > > > > > realpath wasn't available in our vanilla Vagrant environment. Perhaps > > add a check and/or apt-get it? > > Bill Fa

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > LGTM overall. I don't have enough docker/debian expertise to deliver best > > value though. If you are not willing to give a ship, can you please tap someone who you would be more comfortable with giving one? > On Aug. 10, 2015, 5:3

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94760 --- LGTM overall. I don't have enough docker/debian expertise to deliver

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94604 --- Ping - Maxim, any thoughts on this? - Bill Farner On Aug. 5, 2015

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 5, 2015, 5:32 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 5, 2015, 3:12 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

> On Aug. 5, 2015, 1:13 p.m., Jake Farrell wrote: > > build-artifact.sh, line 32 > > > > > > sudo should not be needed and should be removed. > > > > Would be good to add a check to ensure docker is running a

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94238 --- builder/deb/ubuntu-trusty/Dockerfile (line 50)

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94236 --- build-artifact.sh (line 32)