Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 18, 2015, 9:23 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95775 --- Ship it! Looks much better with the services change, thanks! Scre

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95669 --- Ship it! Master (22f9cbb) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 17, 2015, 9:55 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95465 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 14, 2015, 7:17 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 606 > > > > > > You can just do BaseJobController($scope, ...) now? Here and in other > > invoca

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/app.js, lines 35-38 > > > > > > I feel like changing our URLs like this needs a deprecation path. This > > would break

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95427 --- src/main/resources/scheduler/assets/js/app.js (lines 35 - 38)

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95425 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 13, 2015, 9:48 p.m., David McLaughlin wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 334 > > > > > > Why bind to this? Leftover cruft from an earlier implementation (wherein I had p

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 14, 2015, 2:44 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95338 --- src/main/resources/scheduler/assets/js/controllers.js (line 334)

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95329 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 13, 2015, 6:42 p.m

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95319 --- Ship it! Master (887ffd2) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 13, 2015, 6:42 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95115 --- Ship it! Master (cbc42c4) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

> On Aug. 12, 2015, 4:26 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/base.py, line 176 > > > > > > Drive by comment: Nothing's using this new arg yet. Suggest moving > > instance_id suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 12, 2015, 4:40 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95107 --- Ship it! Master (cbc42c4) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95024 --- src/main/python/apache/aurora/client/base.py (line 176)

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95098 --- Master (cbc42c4) is red with this patch. ./build-support/jenkins/b

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 12, 2015, 4:08 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 12, 2015, 3:49 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95094 --- Master (cbc42c4) is red with this patch. ./build-support/jenkins/b

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 12, 2015, 3:29 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95017 --- Master (cbc42c4) is red with this patch. ./build-support/jenkins/b

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 11, 2015, 9:56 p.m.) Review request for Aurora, David McLaughlin