Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Sept. 3, 2015, 4:23 a.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Zameer Manji
> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255 > > > > > > What's being tested here? Are you trying to determine whether the task > > executed

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97498 --- Ship it! Ship It! - Bill Farner On Sept. 2, 2015, 9:45 a.m., Max

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Bill Farner
> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255 > > > > > > What's being tested here? Are you trying to determine whether the task > > executed

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Maxim Khutornenko
> On Sept. 2, 2015, 4:53 p.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255 > > > > > > What's being tested here? Are you trying to determine whether the task > > executed

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97490 --- Ship it! Master (64c00f1) is green with this patch. ./build-suppo

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97480 --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (line 255)

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Sept. 2, 2015, 4:45 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-02 Thread Maxim Khutornenko
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 322 > > > > > > We probably only want to create a job using revocable resources and > > watch that it

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Bill Farner
> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote: > > examples/vagrant/upstart/mesos-slave.conf, line 38 > > > > > > any reason for the verbosity? Why not just 'fixed_estimator' or > > something equally brief? > >

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97325 --- Ship it! Master (5a7bd34) is green with this patch. ./build-suppo

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97315 --- @ReviewBot retry - Maxim Khutornenko On Sept. 1, 2015, 5:15 p.m.,

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97308 --- Master (f285647) is red with this patch. ./build-support/jenkins/b

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Sept. 1, 2015, 5:15 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Maxim Khutornenko
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote: > > examples/vagrant/upstart/mesos-slave.conf, line 38 > > > > > > any reason for the verbosity? Why not just 'fixed_estimator' or > > something equally brief? Thi

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97200 --- Ship it! Master (c8e65d3) is green with this patch. ./build-suppo

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97195 --- examples/vagrant/upstart/mesos-slave.conf (line 38)

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97187 --- Ship it! Ship It! - Zameer Manji On Aug. 31, 2015, 3:53 p.m., Ma

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Aug. 31, 2015, 10:53 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97183 --- Master (89da936) is red with this patch. ./build-support/jenkins/b

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Aug. 31, 2015, 10:25 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Aug. 31, 2015, 10:25 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Aug. 29, 2015, 9:04 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-08-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review96998 --- This patch does not apply cleanly on master (782f883), do you need t