Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/ --- (Updated Jan. 20, 2016, 2:36 p.m.) Review request for Aurora, John Sirois and M

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114830 --- src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrune

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread John Sirois
> On Jan. 15, 2016, 4:33 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 152 > > > > > > You could centralize this handling in deleteTasks - it has all

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Zameer Manji
> On Jan. 15, 2016, 3:33 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 152 > > > > > > You could centralize this handling in deleteTasks - it has all

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114795 --- src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrune

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Zameer Manji
> On Jan. 15, 2016, 9:57 a.m., Maxim Khutornenko wrote: > > History prunner is regsistered as a service. Shouldn't its failure triger a > > shutdown according to this: https://reviews.apache.org/r/39631? `TaskHistoryPruner` is not a service, only `JobUpdateHistoryPruner` is. Even if this was a

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114732 --- History prunner is regsistered as a service. Shouldn't its failure

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114623 --- Ship it! Master (4dff5da) is green with this patch. ./build-supp