Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115780 --- Ship it! Ship It! - John Sirois On Jan. 21, 2016, 6:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42628/ > --- > > (Updated Jan. 21, 2016, 6:25 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is partially in response to some discussion on other reviews. > `fetchTask` makes several call sites much more natural (not having to > possibly deal with multiple results), and `mutateTask` actually represents > all but 2 call sites that modifies tasks. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 4fa5254457b40feb4bb8b6512c09dd4946935b64 > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > c136d1abc82b0f91f2b148e998e30b6b50856d51 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 720b5e5d14a66412dceaf9d9954c7f5aa01d495c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 610915820b50a73f6757ad60a0e35e3f641f7fdf > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 62639c4879ecd652f4d51a94159f128997c03df5 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > d4061340dc4d9975b6783b6cb38b457632bd4bb0 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > c55dcc94a4ec080fedf85ee792c968e8f119f53a > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > b380f21ac169b4991158f39dc70526e11fca54f0 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 6d4268956acdf85465a3d05191456c74bc426998 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > a6bfc7ac91891330600bd260cc8efff1240007e1 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 5a9b6c1030a6db2190d34bf531deb99dfd8df672 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 430527051df7cd7026ae2754f5a9616e39857468 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > bf344a4ddbc7f294f938df67f27bfdb32cf37457 > > Diff: https://reviews.apache.org/r/42628/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115766 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 22, 2016, 1:25 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42628/ > --- > > (Updated Jan. 22, 2016, 1:25 a.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is partially in response to some discussion on other reviews. > `fetchTask` makes several call sites much more natural (not having to > possibly deal with multiple results), and `mutateTask` actually represents > all but 2 call sites that modifies tasks. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 4fa5254457b40feb4bb8b6512c09dd4946935b64 > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > c136d1abc82b0f91f2b148e998e30b6b50856d51 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 720b5e5d14a66412dceaf9d9954c7f5aa01d495c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 610915820b50a73f6757ad60a0e35e3f641f7fdf > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 62639c4879ecd652f4d51a94159f128997c03df5 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > d4061340dc4d9975b6783b6cb38b457632bd4bb0 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > c55dcc94a4ec080fedf85ee792c968e8f119f53a > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > b380f21ac169b4991158f39dc70526e11fca54f0 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 6d4268956acdf85465a3d05191456c74bc426998 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > a6bfc7ac91891330600bd260cc8efff1240007e1 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 5a9b6c1030a6db2190d34bf531deb99dfd8df672 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 430527051df7cd7026ae2754f5a9616e39857468 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > bf344a4ddbc7f294f938df67f27bfdb32cf37457 > > Diff: https://reviews.apache.org/r/42628/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115763 --- Ship it! Master (c89fecb) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 22, 2016, 1:25 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42628/ > --- > > (Updated Jan. 22, 2016, 1:25 a.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is partially in response to some discussion on other reviews. > `fetchTask` makes several call sites much more natural (not having to > possibly deal with multiple results), and `mutateTask` actually represents > all but 2 call sites that modifies tasks. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 4fa5254457b40feb4bb8b6512c09dd4946935b64 > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > c136d1abc82b0f91f2b148e998e30b6b50856d51 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 720b5e5d14a66412dceaf9d9954c7f5aa01d495c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 610915820b50a73f6757ad60a0e35e3f641f7fdf > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 62639c4879ecd652f4d51a94159f128997c03df5 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > d4061340dc4d9975b6783b6cb38b457632bd4bb0 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > c55dcc94a4ec080fedf85ee792c968e8f119f53a > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > b380f21ac169b4991158f39dc70526e11fca54f0 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 6d4268956acdf85465a3d05191456c74bc426998 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > a6bfc7ac91891330600bd260cc8efff1240007e1 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 5a9b6c1030a6db2190d34bf531deb99dfd8df672 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 430527051df7cd7026ae2754f5a9616e39857468 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > bf344a4ddbc7f294f938df67f27bfdb32cf37457 > > Diff: https://reviews.apache.org/r/42628/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115757 --- @ReviewBot retry - Bill Farner On Jan. 21, 2016, 5:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42628/ > --- > > (Updated Jan. 21, 2016, 5:25 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is partially in response to some discussion on other reviews. > `fetchTask` makes several call sites much more natural (not having to > possibly deal with multiple results), and `mutateTask` actually represents > all but 2 call sites that modifies tasks. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 4fa5254457b40feb4bb8b6512c09dd4946935b64 > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > c136d1abc82b0f91f2b148e998e30b6b50856d51 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 720b5e5d14a66412dceaf9d9954c7f5aa01d495c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 610915820b50a73f6757ad60a0e35e3f641f7fdf > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 62639c4879ecd652f4d51a94159f128997c03df5 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > d4061340dc4d9975b6783b6cb38b457632bd4bb0 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > c55dcc94a4ec080fedf85ee792c968e8f119f53a > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > b380f21ac169b4991158f39dc70526e11fca54f0 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 6d4268956acdf85465a3d05191456c74bc426998 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > a6bfc7ac91891330600bd260cc8efff1240007e1 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 5a9b6c1030a6db2190d34bf531deb99dfd8df672 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 430527051df7cd7026ae2754f5a9616e39857468 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > bf344a4ddbc7f294f938df67f27bfdb32cf37457 > > Diff: https://reviews.apache.org/r/42628/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115756 --- Master (a2c7ccc) is red with this patch. ./build-support/jenkins/build.sh [1m self._clock.tick(0.5 + epsilon)[0m [1m self._clock.converge(threads=[hct.threaded_health_checker])[0m [1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m [1m assert hct._total_latency == 0.5[0m [1m assert hct.metrics.sample()['total_latency_secs'] == 0.5[0m [1m assert hct.metrics.sample()['checks'] == 1[0m [1m[0m [1m # tick again[0m [1m self._clock.tick(1.0 + epsilon)[0m [1m self._clock.converge(threads=[hct.threaded_health_checker])[0m [1m self._clock.tick(0.5 + epsilon)[0m [1m self._clock.converge(threads=[hct.threaded_health_checker])[0m [1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m [1m> assert hct._total_latency == 1.0[0m [1m[31mE AssertionError: assert 1.0036 == 1.0[0m [1m[31mE + where 1.0036 = ._total_latency[0m src/test/python/apache/aurora/executor/common/test_health_checker.py:184: AssertionError -- Captured stderr call -- [] Time now: 0.0 [] Time now: 0.0 [] Time now: 1.0 [] Time now: 1.001 [] Time now: 1.001 [] Time now: 1.5 [] Time now: 1.502 [] Time now: 1.502 [] Time now: 2.5 [] Time now: 2.503 [] Time now: 2.503 [] Time now: 3.0 [] Time now: 3.004 generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.common.common.xml [1m[31m= 1 failed, 42 passed, 2 skipped in 3.71 seconds =[0m FAILURE 01:35:39 05:04 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 22, 2016, 1:25 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42628/ > --- > > (Updated Jan. 22, 2016, 1:25 a.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is partially in response to some discussion on other reviews. > `fetchTask` makes several call sites much more natural (not having to > possibly deal with multiple results), and `mutateTask` actually represents > all but 2 call sites that modifies tasks. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 4fa5254457b40feb4bb8b6512c09dd4946935b64 > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > c136d1abc82b0f91f2b148e998e30b6b50856d51 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 720b5e5d14a66412dceaf9d9954c7f5aa01d495c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 610915820b50a73f6757ad60a0e35e3f641f7fdf > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 62639c4879ecd652f4d51a94159f128997c03df5 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > d4061340dc4d9975b6783b6cb38b457632bd4bb0 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > c55dcc94a4ec080fedf85ee792c968e8f119f53a > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > b380f21ac169b4991158f39dc70526e11fca54f0 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 6d4268956acdf85465a3d05191456c74bc426998 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > a6bfc7ac91891330600bd260cc8efff1240007e1 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 5a9b6c1030a6db2190d34bf531deb99dfd8df672 > src/t
Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115754 --- Related discussion, i would like to evaluate removing this function: ``` ImmutableSet mutateTasks( Query.Builder query, Function mutator); ``` The function itself is only called in `StorageBackfill`, and could be replaced by a query + selective mutations. - Bill Farner On Jan. 21, 2016, 5:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42628/ > --- > > (Updated Jan. 21, 2016, 5:25 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > This is partially in response to some discussion on other reviews. > `fetchTask` makes several call sites much more natural (not having to > possibly deal with multiple results), and `mutateTask` actually represents > all but 2 call sites that modifies tasks. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 4fa5254457b40feb4bb8b6512c09dd4946935b64 > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > c136d1abc82b0f91f2b148e998e30b6b50856d51 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 720b5e5d14a66412dceaf9d9954c7f5aa01d495c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 610915820b50a73f6757ad60a0e35e3f641f7fdf > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 62639c4879ecd652f4d51a94159f128997c03df5 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > d4061340dc4d9975b6783b6cb38b457632bd4bb0 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > c55dcc94a4ec080fedf85ee792c968e8f119f53a > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > b380f21ac169b4991158f39dc70526e11fca54f0 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 6d4268956acdf85465a3d05191456c74bc426998 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > a6bfc7ac91891330600bd260cc8efff1240007e1 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 5a9b6c1030a6db2190d34bf531deb99dfd8df672 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 430527051df7cd7026ae2754f5a9616e39857468 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > bf344a4ddbc7f294f938df67f27bfdb32cf37457 > > Diff: https://reviews.apache.org/r/42628/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >