Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-20 Thread Pierre Cheynier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/
---

(Updated April 20, 2016, 3:38 p.m.)


Review request for Aurora and John Sirois.


Bugs: AURORA-1568
https://issues.apache.org/jira/browse/AURORA-1568


Repository: aurora-packaging


Description
---

An operator should be able to build Aurora on his platform without
relying on Docker.

Even if this is an interesting way of doing it, it sometimes introduce missed
(build-)dependencies (in this case openssl) and context-specific behaviour
(here, the way pants.ini was added to the build context)


Diffs
-

  builder/deb/debian-jessie/Dockerfile fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
  builder/deb/debian-jessie/pants.ini 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
  builder/deb/ubuntu-trusty/Dockerfile a4a9e648537841583fdc02c006bfa00a3a095aca 
  builder/deb/ubuntu-trusty/pants.ini  
  builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
  builder/rpm/centos-7/pants.ini  
  specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
  specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
  specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
  specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 

Diff: https://reviews.apache.org/r/45298/diff/


Testing
---

Able to build on CentOS 6 using mock.
Able to build on Debian. Limitation = need the patched version of Gradle.
Still able to build using the current Docker build system


Thanks,

Pierre Cheynier

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-20 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review129817
---


Ship it!




Thanks Pierre - this is great!

- John Sirois


On April 19, 2016, 5:34 p.m., Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated April 19, 2016, 5:34 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
>   builder/deb/debian-jessie/pants.ini 
> 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
>   builder/deb/ubuntu-trusty/Dockerfile 
> a4a9e648537841583fdc02c006bfa00a3a095aca 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
>   specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-19 Thread Pierre Cheynier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/
---

(Updated avr. 19, 2016, 11:34 après-midi)


Review request for Aurora and John Sirois.


Changes
---

Re-introduce `tr '-' '_'` on AURORA_VERSION to be able to build suffixed 
version number with rpmbuild.


Repository: aurora-packaging


Description
---

An operator should be able to build Aurora on his platform without
relying on Docker.

Even if this is an interesting way of doing it, it sometimes introduce missed
(build-)dependencies (in this case openssl) and context-specific behaviour
(here, the way pants.ini was added to the build context)


Diffs (updated)
-

  builder/deb/debian-jessie/Dockerfile fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
  builder/deb/debian-jessie/pants.ini 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
  builder/deb/ubuntu-trusty/Dockerfile a4a9e648537841583fdc02c006bfa00a3a095aca 
  builder/deb/ubuntu-trusty/pants.ini  
  builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
  builder/rpm/centos-7/pants.ini  
  specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
  specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
  specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
  specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 

Diff: https://reviews.apache.org/r/45298/diff/


Testing
---

Able to build on CentOS 6 using mock.
Able to build on Debian. Limitation = need the patched version of Gradle.
Still able to build using the current Docker build system


Thanks,

Pierre Cheynier

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-19 Thread Pierre Cheynier 


> On avr. 19, 2016, 6:32 après-midi, John Sirois wrote:
> > Thanks for plugging away at this.  It sounds like you were trying to get 
> > versions like '0.13.1-SNAPSHOT' working but they still don't (see below).  
> > As such I'm not sure what the new AURORA_INTERNAL_VERSION is buying.
> 
> Pierre Cheynier wrote:
> AURORA_INTERNAL_VERSION is a way for rpmbuild to properly unpack the tgz 
> archive created with git archive (used in %setup -n).
> 
> But the whole thing is working by passing a version number without 
> "-SNAPSHOT".
> As stated above, I'm now able to build using `./build-artifact.sh 
> /tmp/snapshot.tar.gz 0.13.2`, even on the 0.13.1-SNAPSHOT sources.
> This will produce 0.13.2 debs and rpms.
> 
> This doesn't fully resolve AURORA-1568 if the purpose was to build 
> -SNAPSHOT rpms. The idea here would be to use the Release attribute of the 
> spec file. From my point of view, this is out of the scope of this review. 
> What do you think ?

All things considered, this has no impact on my side.
I'll re-introduce the `export AURORA_VERSION | tr '-' '_'` in the build.sh 
script, so we are able to build using the exact content of .auroraversion.
A new feature here is that we are now free to put an arbitrary version number, 
and the rpm part is able to unpack the tgz properly, using 
AURORA_INTERNAL_VERSION.


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review129587
---


On avr. 19, 2016, 5:48 après-midi, Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated avr. 19, 2016, 5:48 après-midi)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
>   builder/deb/debian-jessie/pants.ini 
> 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
>   builder/deb/ubuntu-trusty/Dockerfile 
> a4a9e648537841583fdc02c006bfa00a3a095aca 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/build.sh be3c6fb970dbdd1b94630473e6f67e4a91700e43 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
>   specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-19 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review129587
---



Thanks for plugging away at this.  It sounds like you were trying to get 
versions like '0.13.1-SNAPSHOT' working but they still don't (see below).  As 
such I'm not sure what the new AURORA_INTERNAL_VERSION is buying.


specs/rpm/Makefile 


Previously, AURORA_VERSION had `tr '-' '_'` treatment both here and in 
builder/rpm/centos-7/build.sh.  Its true this should never have happened in 2 
spots, but it should still be happening here to handle versions like 
0.13.1-SNAPSHOT - which is an illegal rpm version string and causes this blowup:
```
(aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o 
/tmp/snapshot.tar.gz HEAD
$ tar -tzf /tmp/snapshot.tar.gz | head -1
apache-aurora-0.13.1-SNAPSHOT/
(aurora-packaging) $ ./build-artifact.sh /tmp/snapshot.tar.gz 
0.13.1-SNAPSHOT
Using docker image aurora-centos-7
...
+ make srpm
rm -rf /dist/rpmbuild
mkdir -p /dist/rpmbuild/BUILD
mkdir -p /dist/rpmbuild/BUILDROOT
mkdir -p /dist/rpmbuild/RPMS
mkdir -p /dist/rpmbuild/SOURCES
mkdir -p /dist/rpmbuild/SRPMS
cp /src.tar.gz /dist/rpmbuild/SOURCES/apache-aurora-0.13.1-SNAPSHOT.tar.gz
cp SOURCES/* /dist/rpmbuild/SOURCES
rpmbuild  \
--define "_topdir /dist" \
--define "_builddir %{_topdir}/rpmbuild/BUILD" \
--define "_buildrootdir %{_topdir}/rpmbuild/BUILDROOT" \
--define "_rpmdir %{_topdir}/rpmbuild/RPMS" \
--define "_srcrpmdir %{_topdir}/rpmbuild/SRPMS" \
--define "_specdir %(pwd)" \
--define "_sourcedir  %{_topdir}/rpmbuild/SOURCES" \
--define "AURORA_VERSION 0.13.1-SNAPSHOT" \
--define "AURORA_INTERNAL_VERSION 0.13.1-SNAPSHOT" \
--define "MESOS_VERSION 0.26.0" \
--nodeps -bs aurora.spec
error: line 58: Illegal char '-' in: Version:   0.13.1-SNAPSHOT
make: *** [srpm] Error 1
```

Without your patch the blowup was further along:
```
...
+ make srpm
rm -rf /dist/rpmbuild
mkdir -p /dist/rpmbuild/BUILD
mkdir -p /dist/rpmbuild/BUILDROOT
mkdir -p /dist/rpmbuild/RPMS
mkdir -p /dist/rpmbuild/SOURCES
mkdir -p /dist/rpmbuild/SRPMS
cp /src.tar.gz /dist/rpmbuild/SOURCES/0.13.1_SNAPSHOT.tar.gz
cp SOURCES/* /dist/rpmbuild/SOURCES
rpmbuild  \
--define "_topdir /dist" \
--define "_builddir %{_topdir}/rpmbuild/BUILD" \
--define "_buildrootdir %{_topdir}/rpmbuild/BUILDROOT" \
--define "_rpmdir %{_topdir}/rpmbuild/RPMS" \
--define "_srcrpmdir %{_topdir}/rpmbuild/SRPMS" \
--define "_specdir %(pwd)" \
--define "_sourcedir  %{_topdir}/rpmbuild/SOURCES" \
--define "AURORA_VERSION 0.13.1_SNAPSHOT" \
--define "MESOS_VERSION 0.26.0" \
--nodeps -bs aurora.spec
Wrote: 
/dist/rpmbuild/SRPMS/aurora-scheduler-0.13.1_SNAPSHOT-1.el7.centos.aurora.src.rpm
+ yum-builddep -y 
../../../dist/rpmbuild/SRPMS/aurora-scheduler-0.13.1_SNAPSHOT-1.el7.centos.aurora.src.rpm
...
cp /src.tar.gz /dist/rpmbuild/SOURCES/0.13.1_SNAPSHOT.tar.gz
cp SOURCES/* /dist/rpmbuild/SOURCES
rpmbuild  \
--define "_topdir /dist" \
--define "_builddir %{_topdir}/rpmbuild/BUILD" \
--define "_buildrootdir %{_topdir}/rpmbuild/BUILDROOT" \
--define "_rpmdir %{_topdir}/rpmbuild/RPMS" \
--define "_srcrpmdir %{_topdir}/rpmbuild/SRPMS" \
--define "_specdir %(pwd)" \
--define "_sourcedir  %{_topdir}/rpmbuild/SOURCES" \
--define "AURORA_VERSION 0.13.1_SNAPSHOT" \
--define "MESOS_VERSION 0.26.0" \
-ba aurora.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.gcBcSI
+ umask 022
+ cd /dist/rpmbuild/BUILD
+ cd /dist/rpmbuild/BUILD
+ rm -rf apache-aurora-0.13.1_SNAPSHOT
+ /usr/bin/gzip -dc /dist/rpmbuild/SOURCES/0.13.1_SNAPSHOT.tar.gz
+ /usr/bin/tar -xvvf -
drwxrwxr-x root/root 0 2016-04-18 21:52 
apache-aurora-0.13.1-SNAPSHOT/
-rw-rw-r-- root/root16 2016-04-18 21:52 
apache-aurora-0.13.1-SNAPSHOT/.auroraversion
-rw-rw-r-- root/root35 2016-04-18 21:52 
apache-aurora-0.13.1-SNAPSHOT/.bowerrc
...
-rw-rw-r-- root/root  1483 2016-04-18 21:52 
apache-aurora-0.13.1-SNAPSHOT/src/test/sh/org/apache/aurora/e2e/validate_serverset.py
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd apache-aurora-0.13.1_SNAPSHOT
/var/tmp/rpm-tmp.gcBcSI: line 35: cd: apache-aurora-0.13.1_SNAPSHOT: No 
such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.gcBcSI (%prep)

RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.gcBcSI (%prep)
make: *** [rpm] Error 1
```


- John Sirois


On April 19, 2016, 11:48

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-19 Thread Pierre Cheynier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/
---

(Updated April 19, 2016, 11:44 a.m.)


Review request for Aurora and John Sirois.


Changes
---

Pierre - looks like you solved AURORA-1568 so linking that bug.


Bugs: AURORA-1568
https://issues.apache.org/jira/browse/AURORA-1568


Repository: aurora-packaging


Description
---

An operator should be able to build Aurora on his platform without
relying on Docker.

Even if this is an interesting way of doing it, it sometimes introduce missed
(build-)dependencies (in this case openssl) and context-specific behaviour
(here, the way pants.ini was added to the build context)


Diffs
-

  builder/deb/debian-jessie/Dockerfile fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
  builder/deb/debian-jessie/pants.ini 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
  builder/deb/ubuntu-trusty/Dockerfile a4a9e648537841583fdc02c006bfa00a3a095aca 
  builder/deb/ubuntu-trusty/pants.ini  
  builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
  builder/rpm/centos-7/build.sh be3c6fb970dbdd1b94630473e6f67e4a91700e43 
  builder/rpm/centos-7/pants.ini  
  specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
  specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
  specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
  specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 

Diff: https://reviews.apache.org/r/45298/diff/


Testing
---

Able to build on CentOS 6 using mock.
Able to build on Debian. Limitation = need the patched version of Gradle.
Still able to build using the current Docker build system


Thanks,

Pierre Cheynier

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-19 Thread Pierre Cheynier 


> On April 13, 2016, 2:51 p.m., John Sirois wrote:
> > Thanks for following up - the source change from github to apache's 
> > download redirector service was a good idea and it seems a more appropriate 
> > source to boot!
> > 
> > This worked for me using `./build-artifact.sh /tmp/snapshot.tar.gz 0.13.0` 
> > only after:
> > ```diff
> > diff --git a/specs/rpm/Makefile b/specs/rpm/Makefile
> > index 0476bcb..950f91e 100644
> > --- a/specs/rpm/Makefile
> > +++ b/specs/rpm/Makefile
> > @@ -21,7 +21,7 @@ DATETIME ?= $(shell date +%Y%m%d%H%M)
> >  AURORA_VERSION ?= $(shell cat $(TOPDIR)/.auroraversion | tr '-' '.')
> >  MESOS_VERSION ?= $(shell tr -d "'\" \t" < $(TOPDIR)/3rdparty/python/BUILD 
> > | sed -n 's/MESOS_REV=(.*)/\1/p' )
> >  
> > -SOURCE_TARGET ?= $(RPM_TOPDIR)/rpmbuild/SOURCES/$(AURORA_VERSION).tar.gz
> > +SOURCE_TARGET ?= 
> > $(RPM_TOPDIR)/rpmbuild/SOURCES/apache-aurora-$(AURORA_VERSION).tar.gz
> >  
> >  PHONY: all nightly_version release_version get_source_target clean mkdir 
> > srpm nightly_srpm nightly_rpm release_srpm release_rpm tar_source
> > ```
> > 
> > If you add that change and rebase (there were changes to the removed/moved 
> > pants.ini in https://reviews.apache.org/r/45662/) - this change LGTM and 
> > I'll patch it in.

Hi, I think this is not sufficient.

Therotically, we should be able to build Aurora from the spec file "as is", but 
also from any git branch (including a SNAPSHOT version).

This is why I propose this patch : for the centos builder, we introduce the 
notion of AURORA_INTERNAL_VERSION, which is the content of .auroraversion. It 
helps locating the sources, but the final RPM will be versioned using the 
version arg passed to build-artifact.sh (as it is done for debian/ubuntu 
builders).

I tested it by building the current 0.13.1-SNAPSHOT from sources, and I rebased 
from master.


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review128683
---


On April 19, 2016, 10:48 a.m., Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated April 19, 2016, 10:48 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
>   builder/deb/debian-jessie/pants.ini 
> 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
>   builder/deb/ubuntu-trusty/Dockerfile 
> a4a9e648537841583fdc02c006bfa00a3a095aca 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/build.sh be3c6fb970dbdd1b94630473e6f67e4a91700e43 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
>   specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-19 Thread Pierre Cheynier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/
---

(Updated April 19, 2016, 10:48 a.m.)


Review request for Aurora and John Sirois.


Changes
---

[CentOS] Change the Makefile to consider the target version given from the 
command-line


Repository: aurora-packaging


Description
---

An operator should be able to build Aurora on his platform without
relying on Docker.

Even if this is an interesting way of doing it, it sometimes introduce missed
(build-)dependencies (in this case openssl) and context-specific behaviour
(here, the way pants.ini was added to the build context)


Diffs (updated)
-

  builder/deb/debian-jessie/Dockerfile fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
  builder/deb/debian-jessie/pants.ini 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
  builder/deb/ubuntu-trusty/Dockerfile a4a9e648537841583fdc02c006bfa00a3a095aca 
  builder/deb/ubuntu-trusty/pants.ini  
  builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
  builder/rpm/centos-7/build.sh be3c6fb970dbdd1b94630473e6f67e4a91700e43 
  builder/rpm/centos-7/pants.ini  
  specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
  specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
  specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
  specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 

Diff: https://reviews.apache.org/r/45298/diff/


Testing
---

Able to build on CentOS 6 using mock.
Able to build on Debian. Limitation = need the patched version of Gradle.
Still able to build using the current Docker build system


Thanks,

Pierre Cheynier

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-04-13 Thread Pierre Cheynier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/
---

(Updated April 13, 2016, 10:47 a.m.)


Review request for Aurora and John Sirois.


Changes
---

Move RPM source from github.com to apache.org


Repository: aurora-packaging


Description
---

An operator should be able to build Aurora on his platform without
relying on Docker.

Even if this is an interesting way of doing it, it sometimes introduce missed
(build-)dependencies (in this case openssl) and context-specific behaviour
(here, the way pants.ini was added to the build context)


Diffs (updated)
-

  builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f 
  builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
  builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4 
  builder/deb/ubuntu-trusty/pants.ini  
  builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
  builder/rpm/centos-7/pants.ini  
  specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
  specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
  specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 

Diff: https://reviews.apache.org/r/45298/diff/


Testing
---

Able to build on CentOS 6 using mock.
Able to build on Debian. Limitation = need the patched version of Gradle.
Still able to build using the current Docker build system


Thanks,

Pierre Cheynier

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-25 Thread John Sirois 


> On March 24, 2016, 12:04 p.m., John Sirois wrote:
> > specs/rpm/aurora.spec, line 146
> > 
> >
> > This breaks the release script, you can try something like this - it 
> > needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 
> > 0.12.0`
> 
> Pierre Cheynier wrote:
> Hi John.
> This is why I edited the README (AFAIK, this is a pure naming convention 
> introduced by the README). 
> 
> I changed it to be able to make the aurora.spec work (see Source0 : it 
> fetch Aurora sources from github).
> 
> Pierre Cheynier wrote:
> Let me know, maybe it was not the good approach. I was initially 
> wondering why I was not able to simply build the RPM with spectool + mock (= 
> fetch sources + rpmbuild in a chrooted context).

Gotcha.  The failure I got was from using the official released sources, ie: 
this bit of the README:
> Fetch a source distribution, such as an [official 
> one](https://aurora.apache.org/downloads/).

So that portion of the README needscan update.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
---


On March 24, 2016, 12:04 p.m., Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated March 24, 2016, 12:04 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   README.md 3a7cf45034b7896c23588fed83176468ca627ebc 
>   builder/deb/debian-jessie/Dockerfile 
> 63e89deed9a411b1859ba28ea2572ef4a210da1f 
>   builder/deb/debian-jessie/pants.ini 
> 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 52739100c9593292a7aea2459412c8e49f0155a4 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-25 Thread Pierre Cheynier 


> On mars 24, 2016, 6:04 après-midi, John Sirois wrote:
> > specs/rpm/aurora.spec, line 146
> > 
> >
> > This breaks the release script, you can try something like this - it 
> > needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 
> > 0.12.0`
> 
> Pierre Cheynier wrote:
> Hi John.
> This is why I edited the README (AFAIK, this is a pure naming convention 
> introduced by the README). 
> 
> I changed it to be able to make the aurora.spec work (see Source0 : it 
> fetch Aurora sources from github).

Let me know, maybe it was not the good approach. I was initially wondering why 
I was not able to simply build the RPM with spectool + mock (= fetch sources + 
rpmbuild in a chrooted context).


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
---


On mars 24, 2016, 6:04 après-midi, Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated mars 24, 2016, 6:04 après-midi)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   README.md 3a7cf45034b7896c23588fed83176468ca627ebc 
>   builder/deb/debian-jessie/Dockerfile 
> 63e89deed9a411b1859ba28ea2572ef4a210da1f 
>   builder/deb/debian-jessie/pants.ini 
> 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 52739100c9593292a7aea2459412c8e49f0155a4 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-25 Thread Pierre Cheynier 


> On mars 24, 2016, 6:04 après-midi, John Sirois wrote:
> > specs/rpm/aurora.spec, line 146
> > 
> >
> > This breaks the release script, you can try something like this - it 
> > needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 
> > 0.12.0`

Hi John.
This is why I edited the README (AFAIK, this is a pure naming convention 
introduced by the README). 

I changed it to be able to make the aurora.spec work (see Source0 : it fetch 
Aurora sources from github).


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
---


On mars 24, 2016, 6:04 après-midi, Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated mars 24, 2016, 6:04 après-midi)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   README.md 3a7cf45034b7896c23588fed83176468ca627ebc 
>   builder/deb/debian-jessie/Dockerfile 
> 63e89deed9a411b1859ba28ea2572ef4a210da1f 
>   builder/deb/debian-jessie/pants.ini 
> 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 52739100c9593292a7aea2459412c8e49f0155a4 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-24 Thread John Sirois 


> On March 24, 2016, 12:04 p.m., John Sirois wrote:
> > Right now the working operation of `./build-artifact.sh` for consistent 
> > releases is paramount and use of this repo to make custom builds is 
> > secondary.  The rpm `%setup -n ...` has gone back and forth once already 
> > due to breaking our release process so I'll need you to dig in further and 
> > get the builds working both via `./build-artifact.sh` and for a raw build.

And ideally you could add a test of the non-container build or else your fixes 
will invariably bit-rot (we have nightly Jenkins verification that 
`./build-artifact.sh` works).


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
---


On March 24, 2016, 12:04 p.m., Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated March 24, 2016, 12:04 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   README.md 3a7cf45034b7896c23588fed83176468ca627ebc 
>   builder/deb/debian-jessie/Dockerfile 
> 63e89deed9a411b1859ba28ea2572ef4a210da1f 
>   builder/deb/debian-jessie/pants.ini 
> 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 52739100c9593292a7aea2459412c8e49f0155a4 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-24 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
---



Right now the working operation of `./build-artifact.sh` for consistent 
releases is paramount and use of this repo to make custom builds is secondary.  
The rpm `%setup -n ...` has gone back and forth once already due to breaking 
our release process so I'll need you to dig in further and get the builds 
working both via `./build-artifact.sh` and for a raw build.


specs/rpm/aurora.spec (line 146)


This breaks the release script, you can try something like this - it needs 
to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 0.12.0`


- John Sirois


On March 24, 2016, 11:51 a.m., Pierre Cheynier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> ---
> 
> (Updated March 24, 2016, 11:51 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -
> 
>   README.md 3a7cf45034b7896c23588fed83176468ca627ebc 
>   builder/deb/debian-jessie/Dockerfile 
> 63e89deed9a411b1859ba28ea2572ef4a210da1f 
>   builder/deb/debian-jessie/pants.ini 
> 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 52739100c9593292a7aea2459412c8e49f0155a4 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d2c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> ---
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>