Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146989 --- Ship it! Ship It! - Stephan Erb On Aug. 26, 2016, 5:52

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146920 --- Master (50f47cc) is red with this patch.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/ --- (Updated Aug. 26, 2016, 3:52 a.m.) Review request for Aurora and Maxim

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 25, 2016, 9:48 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 165-168 > > > > > > The `pop` is unnecessary. Luckily the Python interpreter is already > >

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 25, 2016, 11:48 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 487 > > > > > > In the taskfs_isolated case the `cwd` will contain a path within the > > container image.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146860 --- I really like the

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146869 --- Master (50f47cc) is red with this patch.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/ --- (Updated Aug. 25, 2016, 9:26 p.m.) Review request for Aurora and Maxim

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 24, 2016, 11:21 a.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 437 > > > > > > In the `taskfs_isolated` case, `cwd` will be set to a path within the > > container, but

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 24, 2016, 1:21 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 437 > > > > > > In the `taskfs_isolated` case, `cwd` will be set to a path within the > > container, but we

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146844 --- Ship it! Master (50f47cc) is green with this patch.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/ --- (Updated Aug. 25, 2016, 7:28 p.m.) Review request for Aurora and Maxim

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146840 --- Master (50f47cc) is red with this patch.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 24, 2016, 11:21 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, lines > > 117-124 > > > > > > Have you considered reading that value from the

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/ --- (Updated Aug. 25, 2016, 6:54 p.m.) Review request for Aurora and Maxim

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/ --- (Updated Aug. 25, 2016, 6:51 p.m.) Review request for Aurora and Maxim

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146619 --- src/main/python/apache/aurora/executor/common/sandbox.py (line

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146568 --- Ship it! Master (c115ac6) is green with this patch.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 22, 2016, 10:41 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 235 > > > > > > ... then this if would not be needed. One could potentially invoke the sandbox

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146449 --- src/main/python/apache/aurora/executor/aurora_executor.py (line

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146441 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 22, 2016,

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146434 --- Ship it! Master (9b34a40) is green with this patch.