Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-09-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147856 --- Ship it! I'm fine with trimming dead code from our commons fork

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-31 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147493 --- Bumping for Josh. - Zameer Manji On Aug. 26, 2016, 3:11 p.m., Z

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Zameer Manji
> On Aug. 29, 2016, 9:33 a.m., Maxim Khutornenko wrote: > > Not against this change but rather curious what your thoughts are wrt the > > larger picture here. Are you intending to get rid of all static helps in > > `Stats` in favor of the `StatsProvider`? > > Zameer Manji wrote: > Yes, I t

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Maxim Khutornenko
> On Aug. 29, 2016, 4:33 p.m., Maxim Khutornenko wrote: > > Not against this change but rather curious what your thoughts are wrt the > > larger picture here. Are you intending to get rid of all static helps in > > `Stats` in favor of the `StatsProvider`? > > Zameer Manji wrote: > Yes, I t

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Zameer Manji
> On Aug. 29, 2016, 9:33 a.m., Maxim Khutornenko wrote: > > Not against this change but rather curious what your thoughts are wrt the > > larger picture here. Are you intending to get rid of all static helps in > > `Stats` in favor of the `StatsProvider`? Yes, I think the static dependency on

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147138 --- Not against this change but rather curious what your thoughts are

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147036 --- Ship it! Master (4a2aff9) is green with this patch. ./build-s

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/ --- (Updated Aug. 26, 2016, 3:11 p.m.) Review request for Aurora and Joshua Cohen.