Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 11:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see one on JIRA. > > John Sirois wrote: >

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147355 --- Master (c99f2fb) is green with this patch. ./build-support/jenki

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 10:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see one on JIRA. > > John Sirois wrote: >

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/ --- (Updated Aug. 30, 2016, 2:25 p.m.) Review request for Aurora, Joshua Cohen, Ste

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147347 --- This patch does not apply cleanly against master (c99f2fb), do you

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147348 --- Ship it! Ship It! - Joshua Cohen On Aug. 30, 2016, 8 p.m., J

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/ --- (Updated Aug. 30, 2016, 2 p.m.) Review request for Aurora, Joshua Cohen, Stepha

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 12:23 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java, > > line 78 > > > > > > I suggest against placing a version number into th

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 1:23 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, lines 41-42 > > > > > > You once recommended to stop all schedules at once when switching to > > Curator, rather than doing this in a rolling fa

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 11:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see one on JIRA. The language of https://iss

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 6:23 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java, > > line 78 > > > > > > I suggest against placing a version number into the

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147326 --- src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKee

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147322 --- Ship it! LGTM modulo updating the docs about restarting all ins

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 12:23 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, lines 41-42 > > > > > > You once recommended to stop all schedules at once when switching to > > Curator, rather than doing this in a rolling f

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147269 --- Fix it, then Ship it! RELEASE-NOTES.md (lines 41 - 42)

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147247 --- Master (c34f78a) is green with this patch. ./build-support/jenki