Re: Review Request 52777: Use Gradle installDist task rather than installApp.
> On Oct. 12, 2016, 4:41 a.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from 'application' > > to 'distribition' at which point I'm not immediately sure how the [main > > class name](https://github.com/apache/aurora/blob/master/build.gradle#L586) > > is configured in the new regime (maybe the same). > > Stephan Erb wrote: > The changelog says "The installApp task is no longer created by the > application plugin (use installDist instead)." > > I read this as: > > * it is still valid to use the application plugin > * if used, the application plugin will note define the 'installApp" ask > anymore Strange but apparently true. Thanks for reading more closely than I! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- On Oct. 12, 2016, 4:13 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52777/ > --- > > (Updated Oct. 12, 2016, 4:13 a.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora-packaging > > > Description > --- > > The latter was deprecated and finally removed in Gradle 3.0: > > "The installApp task is no longer created by the application plugin > (use installDist instead)." > > https://docs.gradle.org/3.0/release-notes > > > Diffs > - > > specs/debian/rules fc74d1c8c0fd3251828dd2d237ac4ee950a41e42 > > Diff: https://reviews.apache.org/r/52777/diff/ > > > Testing > --- > > ./build-artifact.sh builder/rpm/centos-7 snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/ubuntu-trusty snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/debian-jessie snapshot.tar.gz 0.17-snapshot > > > Thanks, > > Stephan Erb > >
Re: Review Request 52777: Use Gradle installDist task rather than installApp.
> On Oct. 12, 2016, 12:41 p.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from 'application' > > to 'distribition' at which point I'm not immediately sure how the [main > > class name](https://github.com/apache/aurora/blob/master/build.gradle#L586) > > is configured in the new regime (maybe the same). The changelog says "The installApp task is no longer created by the application plugin (use installDist instead)." I read this as: * it is still valid to use the application plugin * if used, the application plugin will note define the 'installApp" ask anymore - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- On Oct. 12, 2016, 12:13 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52777/ > --- > > (Updated Oct. 12, 2016, 12:13 p.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora-packaging > > > Description > --- > > The latter was deprecated and finally removed in Gradle 3.0: > > "The installApp task is no longer created by the application plugin > (use installDist instead)." > > https://docs.gradle.org/3.0/release-notes > > > Diffs > - > > specs/debian/rules fc74d1c8c0fd3251828dd2d237ac4ee950a41e42 > > Diff: https://reviews.apache.org/r/52777/diff/ > > > Testing > --- > > ./build-artifact.sh builder/rpm/centos-7 snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/ubuntu-trusty snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/debian-jessie snapshot.tar.gz 0.17-snapshot > > > Thanks, > > Stephan Erb > >
Re: Review Request 52777: Use Gradle installDist task rather than installApp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- Ship it! Your testing done says this is enough on the aurora-packaging side, but on the [aurora side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the installed plugin probably also needs to be changed from from 'application' to 'distribition' at which point I'm not immediately sure how the [main class name](https://github.com/apache/aurora/blob/master/build.gradle#L586) is configured in the new regime (maybe the same). - John Sirois On Oct. 12, 2016, 4:13 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52777/ > --- > > (Updated Oct. 12, 2016, 4:13 a.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora-packaging > > > Description > --- > > The latter was deprecated and finally removed in Gradle 3.0: > > "The installApp task is no longer created by the application plugin > (use installDist instead)." > > https://docs.gradle.org/3.0/release-notes > > > Diffs > - > > specs/debian/rules fc74d1c8c0fd3251828dd2d237ac4ee950a41e42 > > Diff: https://reviews.apache.org/r/52777/diff/ > > > Testing > --- > > ./build-artifact.sh builder/rpm/centos-7 snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/ubuntu-trusty snapshot.tar.gz 0.17-snapshot > ./build-artifact.sh builder/deb/debian-jessie snapshot.tar.gz 0.17-snapshot > > > Thanks, > > Stephan Erb > >
