Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Joshua Cohen
> On Oct. 10, 2017, 2:29 p.m., Joshua Cohen wrote: > > I'd be shocked if they've been failing for over a year. We've had three > > releases since then and the release candidate verification script runs the > > end to end tests. > > > > If I had to hazard a guess, I'd point the finger at

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187542 --- Ship it! Ship It! - Stephan Erb On Oct. 10, 2017, 8:21

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Stephan Erb
> On Oct. 10, 2017, 4:59 p.m., Stephan Erb wrote: > > I have been running the end-to-end tests from time to time and have not > > seen this problem, yet. > > > > Code wide, I also don't think this should be necessary. We are defaulting > > to json if there is no accept header in order to

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187540 --- I have been running the end-to-end tests from time to time and

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Joshua Cohen
> On Oct. 10, 2017, 2:29 p.m., Joshua Cohen wrote: > > I'd be shocked if they've been failing for over a year. We've had three > > releases since then and the release candidate verification script runs the > > end to end tests. > > > > If I had to hazard a guess, I'd point the finger at

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187536 --- Ship it! Regardless... ship away! - Joshua Cohen On Oct.

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187535 --- I'd be shocked if they've been failing for over a year. We've had

Re: Review Request 62857: Fix broken end-to-end tests

2017-10-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187502 --- Ship it! Master (0169b81) is green with this patch.