Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188860 --- This is pushed to master, feel free to close the RB. - David

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-20 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188852 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 19,

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188790 --- Ship it! Master (5397013) is green with this patch.

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 19, 2017, 10:52 p.m.) Review request for Aurora, David

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 19, 2017, 10:51 p.m.) Review request for Aurora, David

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread David McLaughlin
> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > I'd also try and find a task with a longer job key and see what

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
> On Oct. 17, 2017, 7:50 p.m., Santhosh Kumar Shanmugham wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > Wonder if we need to paginate this? Think the most

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > I'd also try and find a task with a longer job key and see what

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 19, 2017, 10:37 p.m.) Review request for Aurora, David

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188376 --- Ship it! LGTM with comments addressed. File Attachment:

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-17 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188371 --- Ship it! LGTM. Improvement suggested. File Attachment:

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-17 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188341 --- Fix it, then Ship it! LGTM

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188274 --- Ship it! Master (5b72398) is green with this patch.

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-16 Thread Reza Motamedi
> On Oct. 17, 2017, 2:02 a.m., David McLaughlin wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > Host Neighbors? done. > On Oct. 17, 2017, 2:02 a.m., David

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-16 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 17, 2017, 5:34 a.m.) Review request for Aurora, David