Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199934 --- Ship it! Ship It! - Stephan Erb On March 23, 2018, 6:39

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199901 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 23, 2018, 5:39 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

> On March 22, 2018, 11:31 p.m., Stephan Erb wrote: > > src/test/python/apache/thermos/monitoring/BUILD > > Lines 21 (patched) > > > > > > Requests has a few dependencies. I believe you need to list those here > >

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199838 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 22,

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199830 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 23, 2018, 12:59 a.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

> On March 22, 2018, 10:31 p.m., Stephan Erb wrote: > > src/test/python/apache/thermos/monitoring/BUILD > > Lines 21 (patched) > > > > > > Requests has a few dependencies. I believe you need to list those here > >

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199822 --- src/test/python/apache/thermos/monitoring/BUILD Lines 21

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199814 --- Fix it, then Ship it! Implementation LGTM. Some more comments

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199815 --- Master (f32086d) is red with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199812 --- Querying information from Mesos rather than re-doing it in

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 22, 2018, 9:52 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199791 --- src/main/python/apache/thermos/monitoring/disk.py Lines 132

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199763 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 22, 2018, 2:02 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199741 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 22, 2018, 5:29 a.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199735 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 21, 2018, 11:44 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

> On March 21, 2018, 5:39 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/aurora/tools/thermos_observer.py > > Lines 89 (patched) > > > > > > The agent's HTTP endpoints can have AuthN/AuthZ enabled.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199680 --- src/main/python/apache/aurora/tools/thermos_observer.py Lines 89

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199560 --- Ship it! Master (b3fa9fe) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 20, 2018, 5:20 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199521 --- This patch does not apply cleanly against master (b3fa9fe), do

Re: Review Request 66103: Introduce mesos disk collector

> On March 19, 2018, 9 p.m., Santhosh Kumar Shanmugham wrote: > > 3rdparty/python/requirements.txt > > Lines 23 (patched) > > > > > > Any reason not using the more widely used `jq`? There are two python libraries

Re: Review Request 66103: Introduce mesos disk collector

> On March 19, 2018, 11:30 p.m., Kai Huang wrote: > > src/main/python/apache/thermos/monitoring/disk.py > > Lines 96 (patched) > > > > > > Just curious: is there any reason we set this value to -1GB? It is just a

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 20, 2018, 5:37 a.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199448 --- Approach looks good. Few comments on improving the interface and

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199418 --- Master (aaadad7) is red with this patch.