Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/ --- (Updated Aug. 24, 2018, 4:43 p.m.) Review request for Aurora, David

Re: Review Request 66192: [WIP] Variable group size updates

> On May 16, 2018, 2:54 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > > Lines 784-786 (original), 788-828 (patched) > > > > > > Doing such a conversion

Re: Review Request 66192: [WIP] Variable group size updates

> On May 15, 2018, 4:26 a.m., Aurora ReviewBot wrote: > > Master (805a53f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :compileJmhJavaNote: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java > >

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review203292 ---

Re: Review Request 66192: [WIP] Variable group size updates

> On May 14, 2018, 10:58 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > > Lines 826 (patched) > > > > > > Sums up to be exactly

Re: Review Request 66192: [WIP] Variable group size updates

> On May 14, 2018, 7:26 p.m., Aurora ReviewBot wrote: > > Master (805a53f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :compileJmhJavaNote: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java > >

Re: Review Request 66192: [WIP] Variable group size updates

> On May 14, 2018, 10:58 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > > Lines 826 (patched) > > > > > > Sums up to be exactly

Re: Review Request 66192: [WIP] Variable group size updates

> On May 14, 2018, 7:26 p.m., Aurora ReviewBot wrote: > > Master (805a53f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :compileJmhJavaNote: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java > >

Re: Review Request 66192: [WIP] Variable group size updates

> On May 14, 2018, 7:26 p.m., Aurora ReviewBot wrote: > > Master (805a53f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :compileJmhJavaNote: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java > >

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review203093 --- Master (805a53f) is red with this patch.

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/ --- (Updated May 14, 2018, 7:19 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review203048 --- Approach looks good to me.

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review202718 --- Master (805a53f) is red with this patch.

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/ --- (Updated May 8, 2018, 4:26 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66192: [WIP] Variable group size updates

> On March 21, 2018, 10:33 p.m., Jordan Ly wrote: > > I am mostly concerned about the UX. Users will be able to specify both > > batch size and variable batch size and must know that variable batch sizing > > takes precedent over other strategies. > > > > Is it worth it to make a larger

Re: Review Request 66192: [WIP] Variable group size updates

> On March 20, 2018, 9:29 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategy.java > > Lines 107-111 (patched) > > > > > > Is this idea of a step sate

Re: Review Request 66192: [WIP] Variable group size updates

> On March 21, 2018, 2:33 p.m., Jordan Ly wrote: > > I am mostly concerned about the UX. Users will be able to specify both > > batch size and variable batch size and must know that variable batch sizing > > takes precedent over other strategies. > > > > Is it worth it to make a larger

Re: Review Request 66192: [WIP] Variable group size updates

> On March 20, 2018, 9:29 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategy.java > > Lines 107-111 (patched) > > > > > > Is this idea of a step sate

Re: Review Request 66192: [WIP] Variable group size updates

> On March 21, 2018, 2:33 p.m., Jordan Ly wrote: > > I am mostly concerned about the UX. Users will be able to specify both > > batch size and variable batch size and must know that variable batch sizing > > takes precedent over other strategies. > > > > Is it worth it to make a larger

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review199707 --- I am mostly concerned about the UX. Users will be able to specify

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review199635 ---

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review199632 --- Master (f32086d) is red with this patch.