Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner 


> On May 8, 2015, 2:49 a.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 200
> > 
> >
> > Shouldn't we abort if the response is not OK? Also how does this work 
> > when the scheduler fails over?

Thanks, i meant to cover that.  Added the ceremonial 
`context.log_response_and_raise` call.  With regards to failover, it signals a 
problem if failover is considered this high in the stack.  In this case, it's 
dealt with in the API layer with retries based on the response (or lack thereof)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82968
---


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner 


> On May 8, 2015, 1:08 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 205
> > 
> >
> > Since this is also used in "update wait" command, suggest reprhasing to 
> > something like "Current state". Otherwise, a command executed at arbitrary 
> > time may create a false assumption the update has _just_ entered that state.

Thanks, i wasn't crazy about the wording either.


> On May 8, 2015, 1:08 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 239
> > 
> >
> > drop pass

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82958
---


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82968
---



src/main/python/apache/aurora/client/cli/update.py


Shouldn't we abort if the response is not OK? Also how does this work when 
the scheduler fails over?


- Zameer Manji


On May 7, 2015, 6:04 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 6:04 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82959
---

Ship it!


Master (9634d25) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82958
---

Ship it!



src/main/python/apache/aurora/client/cli/update.py


Since this is also used in "update wait" command, suggest reprhasing to 
something like "Current state". Otherwise, a command executed at arbitrary time 
may create a false assumption the update has _just_ entered that state.



src/main/python/apache/aurora/client/cli/update.py


drop pass


- Maxim Khutornenko


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 1:04 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

rebase


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
968d456927de8044b8a8c5ca365464a8fedd3711 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82956
---


This patch does not apply cleanly on master (9634d25), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 12:44 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 12:44 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 12:44 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

neglected to git-add a file.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
8296db5434276910fc4f8470c7a962a8e8e0a9c2 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6fb1f71b7dc787c090fce7b8e7c51baee862f336 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 12:43 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
8296db5434276910fc4f8470c7a962a8e8e0a9c2 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6fb1f71b7dc787c090fce7b8e7c51baee862f336 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko 


> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > 
> >
> > Suggest "--wait-until" for consistency with job create command.
> 
> Bill Farner wrote:
> `--wait-until` accepts states, while this is a flag.  IMHO the name 
> should match the behavior.
> 
> Maxim Khutornenko wrote:
> How about "--wait" then? This would still align well with `job create` 
> and even shorter to type :)
> 
> Bill Farner wrote:
> I'd be okay with that.  Before i make the change - reviewers, what do you 
> think?
> 
> Zameer Manji wrote:
> `--wait` better describes the behaviour IMHO.
> 
> Bill Farner wrote:
> Oh, and should i conclude that the new subcommand should be called 
> `aurora update wait`?

I would not necessarily tie "--wait" option with the "watch" command. The 
option builds on consistency and familiarity with other options while "watch" 
command sets a new precedent, which is totally fine.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 


> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > 
> >
> > Suggest "--wait-until" for consistency with job create command.
> 
> Bill Farner wrote:
> `--wait-until` accepts states, while this is a flag.  IMHO the name 
> should match the behavior.
> 
> Maxim Khutornenko wrote:
> How about "--wait" then? This would still align well with `job create` 
> and even shorter to type :)
> 
> Bill Farner wrote:
> I'd be okay with that.  Before i make the change - reviewers, what do you 
> think?
> 
> Zameer Manji wrote:
> `--wait` better describes the behaviour IMHO.

Oh, and should i conclude that the new subcommand should be called `aurora 
update wait`?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji 


> On May 7, 2015, 5:04 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > 
> >
> > Suggest "--wait-until" for consistency with job create command.
> 
> Bill Farner wrote:
> `--wait-until` accepts states, while this is a flag.  IMHO the name 
> should match the behavior.
> 
> Maxim Khutornenko wrote:
> How about "--wait" then? This would still align well with `job create` 
> and even shorter to type :)
> 
> Bill Farner wrote:
> I'd be okay with that.  Before i make the change - reviewers, what do you 
> think?

`--wait` better describes the behaviour IMHO.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---


On May 7, 2015, 4:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 4:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 


> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > 
> >
> > Suggest "--wait-until" for consistency with job create command.
> 
> Bill Farner wrote:
> `--wait-until` accepts states, while this is a flag.  IMHO the name 
> should match the behavior.
> 
> Maxim Khutornenko wrote:
> How about "--wait" then? This would still align well with `job create` 
> and even shorter to type :)

I'd be okay with that.  Before i make the change - reviewers, what do you think?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko 


> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > 
> >
> > Suggest "--wait-until" for consistency with job create command.
> 
> Bill Farner wrote:
> `--wait-until` accepts states, while this is a flag.  IMHO the name 
> should match the behavior.

How about "--wait" then? This would still align well with `job create` and even 
shorter to type :)


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82944
---

Ship it!


Master (27b5e25) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 


> On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 122
> > 
> >
> > Suggest "--wait-until" for consistency with job create command.

`--wait-until` accepts states, while this is a flag.  IMHO the name should 
match the behavior.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82942
---



src/main/python/apache/aurora/client/cli/update.py


Suggest "--wait-until" for consistency with job create command.


- Maxim Khutornenko


On May 7, 2015, 11:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 7, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
8296db5434276910fc4f8470c7a962a8e8e0a9c2 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6fb1f71b7dc787c090fce7b8e7c51baee862f336 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner