Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84999 --- Ship it! Master (998993d) is green with this patch. ./build-suppo

Re: Review Request 34440: Implementing task reconciler.

> On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 > > > > > > Add @Positive here as well. > > Maxim Khutornenko wrote: > Well, this

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 22, 2015, 8:56 p.m.) Review request for Aurora, Ben Mahler, Joshua

Re: Review Request 34440: Implementing task reconciler.

> On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 > > > > > > Add @Positive here as well. Well, this can and should be 0 as well. We sta

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84992 --- src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84990 --- Master (998993d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 22, 2015, 8:47 p.m.) Review request for Aurora, Ben Mahler, Joshua

Re: Review Request 34440: Implementing task reconciler.

> On May 19, 2015, 11:48 p.m., Zameer Manji wrote: > > Does it make sense for the reconciler to run in parallel with the GC > > executor mechanism? It seems fine to me, but I would like some re-assurance > > here. > > Maxim Khutornenko wrote: > GC executor is not adding anything when task

Re: Review Request 34440: Implementing task reconciler.

> On May 22, 2015, 8:33 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java, line 44 > > > > > > It's kind of odd to abstract this in this way. Do we expect the unit to > >

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84977 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/AsyncModu

Re: Review Request 34440: Implementing task reconciler.

> On May 20, 2015, 12:44 a.m., Ben Mahler wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, lines > > 186-189 > > > > > > Something to consider is that the important time to reconcile is aft

Re: Review Request 34440: Implementing task reconciler.

> On May 20, 2015, 12:44 a.m., Ben Mahler wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, lines > > 186-189 > > > > > > Something to consider is that the important time to reconcile is aft

Re: Review Request 34440: Implementing task reconciler.

> On May 19, 2015, 4:48 p.m., Zameer Manji wrote: > > Does it make sense for the reconciler to run in parallel with the GC > > executor mechanism? It seems fine to me, but I would like some re-assurance > > here. > > Maxim Khutornenko wrote: > GC executor is not adding anything when task r

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84442 --- Ship it! Ship It! - Zameer Manji On May 19, 2015, 6:34 p.m., Max

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84440 --- Ship it! Master (920263b) is green with this patch. ./build-suppo

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 20, 2015, 1:34 a.m.) Review request for Aurora, Ben Mahler, Kevin

Re: Review Request 34440: Implementing task reconciler.

> On May 20, 2015, 12:44 a.m., Ben Mahler wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, lines > > 185-207 > > > > > > Hm.. I thought the approach was going to be to have a flag that togg

Re: Review Request 34440: Implementing task reconciler.

> On May 19, 2015, 11:48 p.m., Zameer Manji wrote: > > Does it make sense for the reconciler to run in parallel with the GC > > executor mechanism? It seems fine to me, but I would like some re-assurance > > here. GC executor is not adding anything when task reconciliation is ON. Is there a p

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84427 --- Thanks Maxim! src/main/java/org/apache/aurora/scheduler/async/Asyn

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84421 --- Does it make sense for the reconciler to run in parallel with the GC

Re: Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84415 --- Ship it! Master (920263b) is green with this patch. ./build-suppo

Review Request 34440: Implementing task reconciler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- Review request for Aurora, Ben Mahler, Kevin Sweeney, and Zameer Manji. Bugs: A