Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/#review92120 --- Ship it! Ship It! - Brian Wickman On July 14, 2015, 12:51 p.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36392/ > --- > > (Updated July 14, 2015, 12:51 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Repository: aurora > > > Description > --- > > Use json.dumps to pretty print the executor config, > and munge it to look right and not get messed with by > the general pretty printer. > Show newlines directly so that multi-line cmdlines look right. > > Make DIFF_VIEWER work for things like "diff -u10" > > > Diffs > - > > src/main/python/apache/aurora/client/cli/jobs.py > 5f608419e1235f14836865b46be05d13963deb37 > src/test/python/apache/aurora/client/cli/test_diff.py > da52105b5c77419ff64e15a30a04f997f9216a7e > > Diff: https://reviews.apache.org/r/36392/diff/ > > > Testing > --- > > Tested in vargant environment. > > > Thanks, > > Brian Brazil > >
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/#review91739 --- Ship it! - Bill Farner On July 14, 2015, 12:51 p.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36392/ > --- > > (Updated July 14, 2015, 12:51 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Repository: aurora > > > Description > --- > > Use json.dumps to pretty print the executor config, > and munge it to look right and not get messed with by > the general pretty printer. > Show newlines directly so that multi-line cmdlines look right. > > Make DIFF_VIEWER work for things like "diff -u10" > > > Diffs > - > > src/main/python/apache/aurora/client/cli/jobs.py > 5f608419e1235f14836865b46be05d13963deb37 > src/test/python/apache/aurora/client/cli/test_diff.py > da52105b5c77419ff64e15a30a04f997f9216a7e > > Diff: https://reviews.apache.org/r/36392/diff/ > > > Testing > --- > > Tested in vargant environment. > > > Thanks, > > Brian Brazil > >
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/#review91611 --- Ship it! Master (1a01a5b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 14, 2015, 12:51 p.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36392/ > --- > > (Updated July 14, 2015, 12:51 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Repository: aurora > > > Description > --- > > Use json.dumps to pretty print the executor config, > and munge it to look right and not get messed with by > the general pretty printer. > Show newlines directly so that multi-line cmdlines look right. > > Make DIFF_VIEWER work for things like "diff -u10" > > > Diffs > - > > src/main/python/apache/aurora/client/cli/jobs.py > 5f608419e1235f14836865b46be05d13963deb37 > src/test/python/apache/aurora/client/cli/test_diff.py > da52105b5c77419ff64e15a30a04f997f9216a7e > > Diff: https://reviews.apache.org/r/36392/diff/ > > > Testing > --- > > Tested in vargant environment. > > > Thanks, > > Brian Brazil > >
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/ --- (Updated July 14, 2015, 12:51 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Update for new style checks Repository: aurora Description --- Use json.dumps to pretty print the executor config, and munge it to look right and not get messed with by the general pretty printer. Show newlines directly so that multi-line cmdlines look right. Make DIFF_VIEWER work for things like "diff -u10" Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil
Re: Review Request 36392: Improve diff output of aurora cli.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36392/#review91609
---
Master (1a01a5b) is red with this patch.
./build-support/jenkins/build.sh
Collecting twitter.common.util==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from
gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from
twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from
twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from
twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython,
twitter.common.lang, twitter.common.string, twitter.common.process,
twitter.common.options, twitter.common.dirutil, twitter.common.log,
twitter.common.contextutil, twitter.common.util, twitter.common.collections,
twitter.common.app, twitter.checkstyle
Running setup.py install for pyflakes
Running setup.py install for pep8
Running setup.py install for smmap
Running setup.py install for gitdb
Running setup.py install for GitPython
Running setup.py install for twitter.common.lang
Running setup.py install for twitter.common.string
Running setup.py install for twitter.common.process
Running setup.py install for twitter.common.options
Running setup.py install for twitter.common.dirutil
Running setup.py install for twitter.common.log
Running setup.py install for twitter.common.contextutil
Running setup.py install for twitter.common.util
Running setup.py install for twitter.common.collections
Running setup.py install for twitter.common.app
Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0 twitter.common.process-0.3.0
twitter.common.string-0.3.0 twitter.common.util-0.3.0
E501:ERROR src/test/python/apache/aurora/client/cli/test_diff.py:096 line too
long (103 > 100 characters)
|assert
subprocess_patch.call_args[0][0].startswith(os.environ.get('DIFF_VIEWER',
'diff') + ' ')
T301:ERROR src/main/python/apache/aurora/client/cli/jobs.py:177 Expected 1
blank lines, found 0
| def __repr__(self):
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On July 14, 2015, 12:31 p.m., Brian Brazil wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36392/
> ---
>
> (Updated July 14, 2015, 12:31 p.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Use json.dumps to pretty print the executor config,
> and munge it to look right and not get messed with by
> the general pretty printer.
> Show newlines directly so that multi-line cmdlines look right.
>
> Make DIFF_VIEWER work for things like "diff -u10"
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/client/cli/jobs.py
> 5f608419e1235f14836865b46be05d13963deb37
> src/test/python/apache/aurora/client/cli/test_diff.py
> da52105b5c77419ff64e15a30a04f997f9216a7e
>
> Diff: https://reviews.apache.org/r/36392/diff/
>
>
> Testing
> ---
>
> Tested in vargant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/ --- (Updated July 14, 2015, 12:31 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora Description --- Use json.dumps to pretty print the executor config, and munge it to look right and not get messed with by the general pretty printer. Show newlines directly so that multi-line cmdlines look right. Make DIFF_VIEWER work for things like "diff -u10" Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/#review91292 --- Master (190daed) is red with this patch. ./build-support/jenkins/build.sh SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_command_hooks.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_supdate.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_cancel_update.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_config_noun.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_create.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_kill.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_status.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_diff.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_inspect.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_update.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_plugins.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_restart.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_cron.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_client.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_api_from_cli.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/util.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_version.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_open.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_context.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/test_hooked_api.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_sla.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_api.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_health_check.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_job_monitor.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater_util.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_scheduler_mux.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_scheduler_client.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_quota_check.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_instance_watcher.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_task_util.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/ --- (Updated July 10, 2015, 12:22 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Fix tests. I keep on forgettings they're in a different tree. Repository: aurora Description --- Use json.dumps to pretty print the executor config, and munge it to look right and not get messed with by the general pretty printer. Show newlines directly so that multi-line cmdlines look right. Make DIFF_VIEWER work for things like "diff -u10" Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil
Re: Review Request 36392: Improve diff output of aurora cli.
> On July 10, 2015, 11:56 a.m., Aurora ReviewBot wrote: > > Master (190daed) is red with this patch. > > ./build-support/jenkins/build.sh > > > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/__init__.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/json.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/http_observer.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/thermos_runner.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/thermos_ckpt.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/__init__.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/loader.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_base.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_helpers.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/__init__.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/bin/config_load.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/bin/config_repl.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/resource.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/disk.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/monitor.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/process.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/__init__.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/detector.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/process_collector_psutil.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/planner.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/options.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/path.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/ckpt.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/constants.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/statuses.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/__init__.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/common.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/main.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/kill.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/read.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/tail.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/simplerun.py > > Everything Looks Good! > > SUCCESS: > > /home/jenk
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/#review91288 --- Master (190daed) is red with this patch. ./build-support/jenkins/build.sh SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/json.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/http_observer.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/thermos_runner.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/thermos_ckpt.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/loader.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_base.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_helpers.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/bin/config_load.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/bin/config_repl.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/resource.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/disk.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/monitor.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/process.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/detector.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/process_collector_psutil.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/planner.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/options.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/path.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/ckpt.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/constants.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/statuses.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/common.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/main.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/kill.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/read.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/tail.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/simplerun.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/run.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/status.py Everything Looks
Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/ --- Review request for Aurora. Repository: aurora Description --- Use json.dumps to pretty print the executor config, and munge it to look right and not get messed with by the general pretty printer. Show newlines directly so that multi-line cmdlines look right. Make DIFF_VIEWER work for things like "diff -u10" Diffs - src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil
