Re: Review Request 37731: Parameterize artifact version in builders.

2015-08-24 Thread Kevin Sweeney
> On Aug. 24, 2015, 3:07 p.m., Kevin Sweeney wrote: > > build-artifact.sh, line 30 > > > > > > For the RPM spec consider making this argument an explicit command-line > > flag (with `--define`) rather than an environ

Re: Review Request 37731: Parameterize artifact version in builders.

2015-08-24 Thread Bill Farner
> On Aug. 24, 2015, 10:07 p.m., Kevin Sweeney wrote: > > build-artifact.sh, line 30 > > > > > > For the RPM spec consider making this argument an explicit command-line > > flag (with `--define`) rather than an enviro

Re: Review Request 37731: Parameterize artifact version in builders.

2015-08-24 Thread Bill Farner
> On Aug. 24, 2015, 10:07 p.m., Kevin Sweeney wrote: > > build-artifact.sh, line 30 > > > > > > For the RPM spec consider making this argument an explicit command-line > > flag (with `--define`) rather than an enviro

Re: Review Request 37731: Parameterize artifact version in builders.

2015-08-24 Thread Bill Farner
> On Aug. 24, 2015, 10:07 p.m., Kevin Sweeney wrote: > > build-artifact.sh, line 30 > > > > > > For the RPM spec consider making this argument an explicit command-line > > flag (with `--define`) rather than an enviro

Re: Review Request 37731: Parameterize artifact version in builders.

2015-08-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37731/#review96221 --- Ship it! build-artifact.sh (line 30)

Review Request 37731: Parameterize artifact version in builders.

2015-08-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37731/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1410 https://issu