Re: Review Request 42042: Proof of concept - param interface implementations defined based on command line args

2016-01-08 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42042/#review113489
---


Just notes, waiting on the discussion thread to settle as you are.


src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java 
(line 85)


This is a simpler scheme for handling generic parsers than the ParserOracle 
in commons args - I like it.



src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java 
(line 152)


com.google.common.reflect.Reflection#newProxy is slightly simpler to use 
here.



src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java 
(line 162)


OK - this took a while to grok, my head was still back in code-genning a 
backing bean for the interface where this is quite a bit more straightforward!  
This will warrant a code comment if implementation proceeds; ie: invoking a 
default method is _barely_ doable if you have java 7+.


- John Sirois


On Jan. 7, 2016, 6:17 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42042/
> ---
> 
> (Updated Jan. 7, 2016, 6:17 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is purely at PoC phase, mostly to serve as an exmaple for a discussion 
> email.  Not yet to be submitted.
> 
> 
> Diffs
> -
> 
>   build.gradle 6d7af5e020afa58040e616caa1911ac69955f0bf 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/parsers/GuavaOptionalParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/parsers/ListParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/MapParser.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/parsers/OptionalParser.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parsers.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/SetParser.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/app/params/CommandLineParametersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 42042: Proof of concept - param interface implementations defined based on command line args

2016-01-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42042/#review113395
---


Master (206a48b) is red with this patch.
  ./build-support/jenkins/build.sh

/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:78:
 Note: Wrote forwarder 
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java:57:
 warning: [rawtypes] found raw type: Parser
  public static final Map> GENERIC_PARSERS = 
ImmutableMap.of(
^
  missing type arguments for generic class Parser
  where T is a type-variable:
T extends Object declared in interface Parser
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java:70:
 warning: [rawtypes] found raw type: Parser
Class parserClass = GENERIC_PARSERS.get(clazz);
^
  missing type arguments for generic class Parser
  where T is a type-variable:
T extends Object declared in interface Parser
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java:154:
 warning: [rawtypes] found raw type: Class
new Class[]{ paramType },
^
  missing type arguments for generic class Class
  where T is a type-variable:
T extends Object declared in class Class
error: warnings found and -Werror specified
1 error
3 warnings
:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 48.494 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 8, 2016, 1:17 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42042/
> ---
> 
> (Updated Jan. 8, 2016, 1:17 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is purely at PoC phase, mostly to serve as an exmaple for a discussion 
> email.  Not yet to be submitted.
> 
> 
> Diffs
> -
> 
>   build.gradle 6d7af5e020afa58040e616caa1911ac69955f0bf 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/parsers/GuavaOptionalParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/parsers/ListParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/MapParser.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/app/params/parsers/OptionalParser.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parsers.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/params/parsers/SetParser.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/app/params/CommandLineParametersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 42042: Proof of concept - param interface implementations defined based on command line args

2016-01-07 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42042/
---

Review request for Aurora and John Sirois.


Repository: aurora


Description
---

This is purely at PoC phase, mostly to serve as an exmaple for a discussion 
email.  Not yet to be submitted.


Diffs
-

  build.gradle 6d7af5e020afa58040e616caa1911ac69955f0bf 
  
src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/app/params/parsers/GuavaOptionalParser.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/params/parsers/ListParser.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/params/parsers/MapParser.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/app/params/parsers/OptionalParser.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parser.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parsers.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/params/parsers/SetParser.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/app/params/CommandLineParametersTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/42042/diff/


Testing
---


Thanks,

Bill Farner