Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115705 --- Ship it! Ship It! - Zameer Manji On Jan. 21, 2016, 12:40 p.m.,

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115695 --- Ship it! Master (8d3fb24) is green with this patch. ./build-supp

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread John Sirois
> On Jan. 21, 2016, 1:28 p.m., John Sirois wrote: > > IIUC the MVCC capabilities in 1.4+ should prevent table locks on all but > > DDL stuff. > > John Sirois wrote: > Hmm - more to the story: "If MVCC is enabled, changing the lock mode > (LOCK_MODE) has no effect." ... Maybe turning on MVC

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115693 --- Ship it! Ship It! - John Sirois On Jan. 21, 2016, 1:40 p.m., Bi

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/ --- (Updated Jan. 21, 2016, 12:40 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Bill Farner
> On Jan. 21, 2016, 12:28 p.m., John Sirois wrote: > > IIUC the MVCC capabilities in 1.4+ should prevent table locks on all but > > DDL stuff. > > John Sirois wrote: > Hmm - more to the story: "If MVCC is enabled, changing the lock mode > (LOCK_MODE) has no effect." ... Maybe turning on MV

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115688 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 21, 2016, 8:25 p.

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Maxim Khutornenko
> On Jan. 21, 2016, 8:28 p.m., John Sirois wrote: > > IIUC the MVCC capabilities in 1.4+ should prevent table locks on all but > > DDL stuff. > > John Sirois wrote: > Hmm - more to the story: "If MVCC is enabled, changing the lock mode > (LOCK_MODE) has no effect." ... Maybe turning on MVC

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread John Sirois
> On Jan. 21, 2016, 1:28 p.m., John Sirois wrote: > > IIUC the MVCC capabilities in 1.4+ should prevent table locks on all but > > DDL stuff. Hmm - more to the story: "If MVCC is enabled, changing the lock mode (LOCK_MODE) has no effect." ... Maybe turning on MVCC is worth some perf tests or

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115684 --- Ship it! IIUC the MVCC capabilities in 1.4+ should prevent table l

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/ --- (Updated Jan. 21, 2016, 12:25 p.m.) Review request for Aurora, John Sirois and

Review Request 42613: Enable READ COMMITTED transaction isolation.

2016-01-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/ --- Review request for Aurora, John Sirois and Zameer Manji. Bugs: AURORA-1580