Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/#review128750 --- Ship it! Ship It! - Zameer Manji On April 13, 2016, 8:09 a.m

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/#review128694 --- Ship it! Master (3cb599e) is green with this patch. ./build-s

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-13 Thread John Sirois
> On April 13, 2016, 9:04 a.m., Bill Farner wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java, > > line 405 > > > > > > s/this.// Fixed. - John ---

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/ --- (Updated April 13, 2016, 9:09 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/#review128688 --- Ship it! commons/src/main/java/org/apache/aurora/common/zookee

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/#review128605 --- Ship it! Master (3cb599e) is green with this patch. ./build-s

Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1468