Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-05-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/
---

(Updated May 4, 2016, 12:24 a.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

As discussed in IRC a couple of days ago, I am opting for the additional 
deprecation cycle.


Bugs: AURORA-945
https://issues.apache.org/jira/browse/AURORA-945


Repository: aurora


Description (updated)
---

This commit introduces a new command line flag `-framework_name` and changes 
the value from the hardcoded 'TwitterScheduler' to 'aurora'.

This change is non-intrusive as 
https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new value 
will be shown on the UI and used for Mesos DNS.


Diffs (updated)
-

  RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
  docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
  docs/reference/scheduler-configuration.md 
d2262f79edfde23eccd87bae7f1cf319b63b1103 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
  
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
 dc964b8dac1b8e21e86ad331216c57fa11abeb6d 

Diff: https://reviews.apache.org/r/46596/diff/


Testing
---

* ./gradlew -Pq build
* Changed the framework name in vagrant. Aurora happily re-registered without a 
fallout.


Thanks,

Stephan Erb

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-29 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review131106
---


Ship it!





RELEASE-NOTES.md (line 6)


Normally i would disagree with this approach, and advocate introducing the 
flag with the existing value as default for this release.
Commenting here to note that in this case it seems better to cut over 
earlier to avoid more pain down the road for newcomers, as there has not been 
much traction on the mesos side to support modifying this field on a live 
cluster.


- Bill Farner


On April 27, 2016, 3:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 27, 2016, 3:44 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-28 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130889
---


Ship it!




Master (e817eb1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 27, 2016, 10:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 27, 2016, 10:44 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130886
---



@ReviewBot retry

- Stephan Erb


On April 28, 2016, 12:44 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 28, 2016, 12:44 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130863
---



Master (e817eb1) is red with this patch.
  ./build-support/jenkins/build.sh

   with temporary_dir() as checkpoint_root:
 te = AuroraExecutor(
 >   
runner_provider=make_provider(checkpoint_root),
 
sandbox_provider=DefaultTestSandboxProvider())
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
 pex_location=thermos_runner_path(),
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 build = True
 
 def thermos_runner_path(build=True):
   if not build:
 return getattr(thermos_runner_path, 'value', 
None)
 
   if not hasattr(thermos_runner_path, 'value'):
 pex_dir = safe_mkdtemp()
 >   assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
   
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
 E   assert 1 == 0
 E+  where 1 = (['./pants', '--pants-distdir=/tmp/user/10021/tmp9D_iDb', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
 E+where  = subprocess.call
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
 -- Captured stderr call --
 Traceback (most recent call last):
   File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", 
line 7, in 
 from pants.bin.pants_exe import main
 ImportError: No module named pants.bin.pants_exe
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  16 failed, 623 passed, 6 skipped, 1 warnings, 8 
error in 150.76 seconds 
 
FAILURE


   Waiting for background workers to finish.
23:10:07 03:26   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 27, 2016, 10:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 27, 2016, 10:44 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/
---

(Updated April 28, 2016, 12:44 a.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

Fix line length + Rebase.


Bugs: AURORA-945
https://issues.apache.org/jira/browse/AURORA-945


Repository: aurora


Description
---

This commit introduces a new command line flag `-framework_name` and changes 
the value from the hardcoded 'TwitterScheduler' to 'aurora'.

This change is non-intrusive as 
https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new value 
will be shown on the UI and used for Mesos DNS. I have skipped a deprecation 
cycle for this change, as if an operator wants to maintain the old value, he 
can simply use the new option when deploying the next Aurora version.


Diffs (updated)
-

  RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
  docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
  docs/reference/scheduler-configuration.md 
d2262f79edfde23eccd87bae7f1cf319b63b1103 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
  
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
 dc964b8dac1b8e21e86ad331216c57fa11abeb6d 

Diff: https://reviews.apache.org/r/46596/diff/


Testing
---

* ./gradlew -Pq build
* Changed the framework name in vagrant. Aurora happily re-registered without a 
fallout.


Thanks,

Stephan Erb

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130857
---



Master (7e30ebe) is red with this patch.
  ./build-support/jenkins/build.sh

:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
 Note: Wrote forwarder 
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:80:
 error: Line is longer than 100 characters (found 107).
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 3 mins 16.989 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 27, 2016, 9:36 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 27, 2016, 9:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/
---

(Updated April 27, 2016, 11:36 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

Warn operators about the potentially risky framework name change.


Bugs: AURORA-945
https://issues.apache.org/jira/browse/AURORA-945


Repository: aurora


Description
---

This commit introduces a new command line flag `-framework_name` and changes 
the value from the hardcoded 'TwitterScheduler' to 'aurora'.

This change is non-intrusive as 
https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new value 
will be shown on the UI and used for Mesos DNS. I have skipped a deprecation 
cycle for this change, as if an operator wants to maintain the old value, he 
can simply use the new option when deploying the next Aurora version.


Diffs (updated)
-

  RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
  docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
  docs/reference/scheduler-configuration.md 
d2262f79edfde23eccd87bae7f1cf319b63b1103 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
  
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
 dc964b8dac1b8e21e86ad331216c57fa11abeb6d 

Diff: https://reviews.apache.org/r/46596/diff/


Testing
---

* ./gradlew -Pq build
* Changed the framework name in vagrant. Aurora happily re-registered without a 
fallout.


Thanks,

Stephan Erb

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130468
---


Ship it!




Ship It!

- Zameer Manji


On April 22, 2016, 5:38 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 22, 2016, 5:38 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Zameer Manji 


> On April 24, 2016, 8:52 a.m., Bill Farner wrote:
> > RELEASE-NOTES.md, line 13
> > 
> >
> > Seems prudent to include a warning about MESOS-703 here and in a doc.
> 
> Maxim Khutornenko wrote:
> +1

+1

It is very very easy to blow away an entire cluster with this.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130307
---


On April 22, 2016, 5:38 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 22, 2016, 5:38 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130447
---


Ship it!




- Maxim Khutornenko


On April 23, 2016, 12:38 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 23, 2016, 12:38 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Maxim Khutornenko 


> On April 24, 2016, 3:52 p.m., Bill Farner wrote:
> > RELEASE-NOTES.md, line 13
> > 
> >
> > Seems prudent to include a warning about MESOS-703 here and in a doc.

+1


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130307
---


On April 23, 2016, 12:38 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 23, 2016, 12:38 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-24 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130307
---



Thanks for doing this, long overdue!

Just one ship block for me - make sure to warn people against shooting 
themselves in the foot.


RELEASE-NOTES.md (line 13)


Seems prudent to include a warning about MESOS-703 here and in a doc.


- Bill Farner


On April 22, 2016, 5:38 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 22, 2016, 5:38 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-22 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130236
---


Ship it!




Master (d339036) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 23, 2016, 12:38 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> ---
> 
> (Updated April 23, 2016, 12:38 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
> https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit introduces a new command line flag `-framework_name` and changes 
> the value from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as 
> https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new 
> value will be shown on the UI and used for Mesos DNS. I have skipped a 
> deprecation cycle for this change, as if an operator wants to maintain the 
> old value, he can simply use the new option when deploying the next Aurora 
> version.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md 
> d2262f79edfde23eccd87bae7f1cf319b63b1103 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> ---
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without 
> a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-22 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/
---

Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Bugs: AURORA-945
https://issues.apache.org/jira/browse/AURORA-945


Repository: aurora


Description
---

This commit introduces a new command line flag `-framework_name` and changes 
the value from the hardcoded 'TwitterScheduler' to 'aurora'.

This change is non-intrusive as 
https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new value 
will be shown on the UI and used for Mesos DNS. I have skipped a deprecation 
cycle for this change, as if an operator wants to maintain the old value, he 
can simply use the new option when deploying the next Aurora version.


Diffs
-

  RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
  docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
  docs/reference/scheduler-configuration.md 
d2262f79edfde23eccd87bae7f1cf319b63b1103 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
  
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
 dc964b8dac1b8e21e86ad331216c57fa11abeb6d 

Diff: https://reviews.apache.org/r/46596/diff/


Testing
---

* ./gradlew -Pq build
* Changed the framework name in vagrant. Aurora happily re-registered without a 
fallout.


Thanks,

Stephan Erb