Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-25 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134856
---


Ship it!




Ship It!

- Stephan Erb


On May 25, 2016, 6:14 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 25, 2016, 6:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-25 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134790
---


Ship it!




Ship It!

- Joshua Cohen


On May 25, 2016, 4:14 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 25, 2016, 4:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-24 Thread Mehrdad Nurolahzade 


> On May 19, 2016, 4:31 p.m., David McLaughlin wrote:
> > src/test/python/apache/aurora/client/cli/test_supdate.py, lines 223-226
> > 
> >
> > Can you add tests to show what happens when the instance ranges will be 
> > empty?

Test scenario test_show_job_update_diff_no_change in test_diff_formatter.py has 
been added to cover this.


- Mehrdad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review133966
---


On May 23, 2016, 9:38 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 23, 2016, 9:38 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-24 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134590
---


Ship it!




Ship It!

- Maxim Khutornenko


On May 23, 2016, 9:38 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 23, 2016, 9:38 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-23 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134460
---


Ship it!




Master (9f6a660) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 23, 2016, 9:38 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 23, 2016, 9:38 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-23 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
---

(Updated May 23, 2016, 9:38 p.m.)


Review request for Aurora.


Changes
---

(1) Refactored test_supdate.py and test_diff.py to use mock.patch()
(2) Cleeaned up unused test fixtures in test_diff_formatter.py


Repository: aurora


Description
---

AURORA-1492 Improve "aurora update start" command output


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
e8bc38aaff42579419130b116389d9b9e09122a9 
  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_diff.py 
b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
  src/test/python/apache/aurora/client/cli/test_diff_formatter.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing
---

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit

Example output:

aurora update start devcluster/www-data/prod/hello 
./aurora/examples/jobs/updated_hello_world.aurora 
 INFO] Starting update for: hello
Job update has started. View your update progress at 
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]


Thanks,

Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-23 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134373
---



Looking much better! A few minor suggestions.


src/main/python/apache/aurora/client/cli/jobs.py (lines 171 - 172)


If the sole purpose of this method is unit test facilitation you can rather 
use mock patch instead.



src/main/python/apache/aurora/client/cli/jobs.py (line 212)


You can import DiffFormatter directly:
```
from apache.aurora.client.cli.diff_formatter import DiffFormatter
```



src/main/python/apache/aurora/client/cli/update.py (lines 162 - 163)


Same as above, use mock patch instead.



src/main/python/apache/aurora/client/cli/update.py (line 177)


Same as above, import directly.



src/test/python/apache/aurora/client/cli/test_diff.py (line 38)


Use 'spec=DiffFormatter' for a stronger assertion of mocked functionality.



src/test/python/apache/aurora/client/cli/test_diff_formatter.py (lines 56 - 58)


You can use it directly from AuroraClientCommandTest. 

Also, to shorten the access points you may want to extend from 
AuroraClientCommandTest rather than from unittest.TestCase.



src/test/python/apache/aurora/client/cli/test_diff_formatter.py (lines 60 - 62)


This is no longer needed if you reference the above from 
AuroraClientCommandTest.



src/test/python/apache/aurora/client/cli/test_diff_formatter.py (lines 113 - 
115)


This seems to be used in only one place, suggest inlining.



src/test/python/apache/aurora/client/cli/test_diff_formatter.py (line 118)


Same here



src/test/python/apache/aurora/client/cli/test_supdate.py (line 100)


Use 'spec=DiffFormatter' for a stronger assertion of mocked functionality.


- Maxim Khutornenko


On May 20, 2016, 10:24 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 20, 2016, 10:24 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-20 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134214
---


Ship it!




Master (f25c9c1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 20, 2016, 10:24 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 20, 2016, 10:24 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-20 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
---

(Updated May 20, 2016, 10:24 p.m.)


Review request for Aurora.


Changes
---

(1) Added test scenario asked by David McLaughlin
(2) Fixed test scenario names
(3) Removed unnecessary test fixtures


Repository: aurora


Description
---

AURORA-1492 Improve "aurora update start" command output


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
e8bc38aaff42579419130b116389d9b9e09122a9 
  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_diff.py 
b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
  src/test/python/apache/aurora/client/cli/test_diff_formatter.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing
---

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit

Example output:

aurora update start devcluster/www-data/prod/hello 
./aurora/examples/jobs/updated_hello_world.aurora 
 INFO] Starting update for: hello
Job update has started. View your update progress at 
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]


Thanks,

Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-20 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134210
---


Ship it!




Master (f25c9c1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 20, 2016, 10:04 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 20, 2016, 10:04 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-20 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
---

(Updated May 20, 2016, 10:04 p.m.)


Review request for Aurora.


Repository: aurora


Description
---

AURORA-1492 Improve "aurora update start" command output


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
e8bc38aaff42579419130b116389d9b9e09122a9 
  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_diff.py 
b9e91cf3be6ebd6d99e588ba2a2df304e42fd832 
  src/test/python/apache/aurora/client/cli/test_diff_formatter.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing
---

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit

Example output:

aurora update start devcluster/www-data/prod/hello 
./aurora/examples/jobs/updated_hello_world.aurora 
 INFO] Starting update for: hello
Job update has started. View your update progress at 
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]


Thanks,

Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134045
---




src/main/python/apache/aurora/client/cli/diff_formatter.py (line 83)


Mark all non-public methods with underscore prefix.



src/main/python/apache/aurora/client/cli/diff_formatter.py (lines 142 - 145)


This was added in one of the previous releases to ensure backwards 
compatibility with older scheduler that didn't have the jobUpdateDiff API. You 
can drop this now.



src/test/python/apache/aurora/client/cli/test_supdate.py (line 247)


Since DiffFormatter is a new component, please move all relevant tests into 
the new test_diff_formatter.py. It's sufficient to mock out any diff_formatter 
entry points in diff and update command tests.


- Maxim Khutornenko


On May 19, 2016, 7:28 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 19, 2016, 7:28 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134018
---




src/main/python/apache/aurora/client/cli/diff_formatter.py (line 145)


This is gonna break for update command (which does not supply local_tasks), 
so it needs to be something like:
self.diff_no_update_details([] if local_tasks is None else local_tasks)


- Mehrdad Nurolahzade


On May 19, 2016, 7:28 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 19, 2016, 7:28 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review134017
---


Ship it!




Master (9ad153f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 19, 2016, 7:28 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 19, 2016, 7:28 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> e8bc38aaff42579419130b116389d9b9e09122a9 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
---

(Updated May 19, 2016, 7:28 p.m.)


Review request for Aurora.


Changes
---

(1) Refactored duplicated code in updates.py and jobs.py to diff_formatter.py
(2) The diff messages are now displayed before the api.start_job_update() call 
is made
(3) Fixed broken tests and added a couple of new scenarios


Repository: aurora


Description
---

AURORA-1492 Improve "aurora update start" command output


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
e8bc38aaff42579419130b116389d9b9e09122a9 
  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing
---

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit

Example output:

aurora update start devcluster/www-data/prod/hello 
./aurora/examples/jobs/updated_hello_world.aurora 
 INFO] Starting update for: hello
Job update has started. View your update progress at 
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]


Thanks,

Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review133966
---




src/test/python/apache/aurora/client/cli/test_supdate.py (lines 223 - 226)


Can you add tests to show what happens when the instance ranges will be 
empty?


- David McLaughlin


On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 18, 2016, 8:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review133811
---


Ship it!




Master (3cbff41) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 18, 2016, 8:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review133809
---




src/main/python/apache/aurora/client/cli/update.py (lines 162 - 182)


Please, move this into something like `diff_formatter.py` and share between 
`jobs.py` and `update.py`. We shouldn't duplicate this functionality.



src/main/python/apache/aurora/client/cli/update.py (line 220)


I suggest moving this call before the `start_job_update()` to give an 
expected change preview right before the update call is placed.


- Maxim Khutornenko


On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 18, 2016, 8:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review133807
---




src/main/python/apache/aurora/client/cli/update.py (line 162)


Copy & pasted from DiffCommand in jobs.py

Any suggestions for how to avoid duplicating this code snippet (and the 
next one) across the two commands?



src/main/python/apache/aurora/client/cli/update.py (line 203)


Copy & pasted from DiffCommand.execute() in jobs.py



src/main/python/apache/aurora/client/cli/update.py (line 205)


What should we do if the api.job_update_diff() call fails?


- Mehrdad Nurolahzade


On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 18, 2016, 8:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/#review133808
---




src/main/python/apache/aurora/client/cli/update.py (lines 162 - 182)


This is copied/pasted almost wholesale from 
https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/cli/jobs.py#L227-L254.
 Can you refactor so this code is shared, rather than duplicated?



src/main/python/apache/aurora/client/cli/update.py (lines 203 - 211)


This is also essentially copied from: 
https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/cli/jobs.py#L302-L312
 (minus some useful error handling).

Can you include this in the refactoring?


- Joshua Cohen


On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47550/
> ---
> 
> (Updated May 18, 2016, 8:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1492 Improve "aurora update start" command output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 2135ca988ce2f260262145a2168849acd8d14874 
> 
> Diff: https://reviews.apache.org/r/47550/diff/
> 
> 
> Testing
> ---
> 
> Automated: ./pants test.pytest --no-fast src/test/python::
> Manual: using vagrant
> e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> Style: ./build-support/hooks/pre-commit
> 
> Example output:
> 
> aurora update start devcluster/www-data/prod/hello 
> ./aurora/examples/jobs/updated_hello_world.aurora 
>  INFO] Starting update for: hello
> Job update has started. View your update progress at 
> http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
> This job update will:
> add instances: [2-3]
> update instances: [0-1]
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
---

(Updated May 18, 2016, 8:55 p.m.)


Review request for Aurora.


Repository: aurora


Description
---

AURORA-1492 Improve "aurora update start" command output


Diffs
-

  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing (updated)
---

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit

Example output:

aurora update start devcluster/www-data/prod/hello 
./aurora/examples/jobs/updated_hello_world.aurora 
 INFO] Starting update for: hello
Job update has started. View your update progress at 
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]


Thanks,

Mehrdad Nurolahzade

Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Mehrdad Nurolahzade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
---

Review request for Aurora.


Repository: aurora


Description
---

AURORA-1492 Improve "aurora update start" command output


Diffs
-

  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing
---

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit


Thanks,

Mehrdad Nurolahzade